From: Harsh Agarwal <quic_harshq@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
Felipe Balbi <balbi@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: <linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_ppratap@quicinc.com>, <quic_jackp@quicinc.com>,
<ahalaney@redhat.com>, Harsh Agarwal <quic_harshq@quicinc.com>
Subject: [PATCH v2 0/3] Add support for multiport controller
Date: Fri, 3 Jun 2022 22:42:39 +0530 [thread overview]
Message-ID: <1654276362-28930-1-git-send-email-quic_harshq@quicinc.com> (raw)
Currently the DWC3 driver supports only single port controller which
requires at most two PHYs ie HS and SS PHYs. There are SoCs that has
DWC3 controller with multiple ports that can operate in host mode. Some of
the port supports both SS+HS and other port supports only HS mode.
This change refactors the PHY logic to support multiport controller. The
implementation has been tested with Generic PHYs as well.
For any multiport controller we would define a new node "multiport" inside
dwc3 and then add subsequent "mport" nodes inside it for individual ports
that it supports. Now each individual "mport" node defines their own PHYs.
e.g.
Consider a Dual port controller where each port supports HS+SS
multiport {
mp_1: mport1 {
usb-phy = <usb2_phy0>, <usb3_phy0>;
/* Can define Generic PHYs also */
};
mp_2: mport2 {
usb-phy = <usb2_phy1>, <usb3_phy1>;
};
Changes in v2:
Changed dwc3_count_phys to return the number of PHY Phandles in the node.
This will be used now in dwc3_extract_num_phys to increment num_usb2_phy
and num_usb3_phy.
Added new parameter "ss_idx" in dwc3_core_get_phy_ny_node and changed its
structure such that the first half is for HS-PHY and second half is for
SS-PHY.
In dwc3_core_get_phy, for multiport controller, only if SS-PHY phandle is
present, pass proper SS_IDX else pass -1.
Harsh Agarwal (3):
dt-bindings: usb: dwc3: Add support for multiport related properties
usb: phy: Add devm_of_usb_get_phy_by_phandle
usb: dwc3: Refactor PHY logic to support Multiport Controller
.../devicetree/bindings/usb/snps,dwc3.yaml | 55 +++
drivers/usb/dwc3/core.c | 403 +++++++++++++++------
drivers/usb/dwc3/core.h | 12 +-
drivers/usb/dwc3/drd.c | 16 +-
drivers/usb/dwc3/gadget.c | 4 +-
drivers/usb/phy/phy.c | 34 ++
include/linux/usb/phy.h | 8 +
7 files changed, 402 insertions(+), 130 deletions(-)
--
2.7.4
next reply other threads:[~2022-06-03 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 17:12 Harsh Agarwal [this message]
2022-06-03 17:12 ` [PATCH v2 1/3] dt-bindings: usb: dwc3: Add support for multiport related properties Harsh Agarwal
2022-06-05 2:17 ` Rob Herring
2022-06-03 17:12 ` [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle Harsh Agarwal
2022-06-06 11:00 ` Sergey Shtylyov
2022-06-08 14:30 ` Harsh Agarwal
2022-06-03 17:12 ` [PATCH v2 3/3] usb: dwc3: Refactor PHY logic to support Multiport Controller Harsh Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1654276362-28930-1-git-send-email-quic_harshq@quicinc.com \
--to=quic_harshq@quicinc.com \
--cc=ahalaney@redhat.com \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_jackp@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).