devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ben Dooks <ben.dooks@sifive.com>
Cc: linux-kernel@vger.kernel.org,
	Greentime Hu <greentime.hu@sifive.com>,
	u.kleine-koenig@pengutronix.de,
	Jude Onyenegecha <jude.onyenegecha@sifive.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org,
	Adnan Chowdhury <adnan.chowdhury@sifive.com>,
	Sudip Mukherjee <sudip.mukherjee@sifive.com>,
	William Salmon <william.salmon@sifive.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-pwm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 3/7] pwm: dwc: add of/platform support
Date: Tue, 12 Jul 2022 08:26:12 -0600	[thread overview]
Message-ID: <1657635972.108769.1805849.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220712100113.569042-4-ben.dooks@sifive.com>

On Tue, 12 Jul 2022 11:01:09 +0100, Ben Dooks wrote:
> The dwc pwm controller can be used in non-PCI systems, so allow
> either platform or OF based probing.
> 
> Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
> ---
>  .../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++
>  drivers/pwm/Kconfig                           |  5 +-
>  drivers/pwm/pwm-dwc.c                         | 53 +++++++++++++++++++
>  3 files changed, 96 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/pwm/pwm-synposys.yaml:11:4: [warning] wrong indentation: expected 2 but found 3 (indentation)
./Documentation/devicetree/bindings/pwm/pwm-synposys.yaml:31:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  parent reply	other threads:[~2022-07-12 14:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 10:01 update synopsys driver for platform/devicetree support Ben Dooks
2022-07-12 10:01 ` [PATCH 1/7] pwm: change &pci->dev to dev in probe Ben Dooks
2022-07-13  8:16   ` Uwe Kleine-König
2022-07-13 10:54     ` Ben Dooks
2022-07-18  7:19     ` Ben Dooks
2022-07-18  7:49       ` Uwe Kleine-König
2022-07-18  7:54         ` Uwe Kleine-König
2022-07-12 10:01 ` [PATCH 2/7] pwm: move dwc memory alloc to own function Ben Dooks
2022-07-12 10:01 ` [PATCH 3/7] pwm: dwc: add of/platform support Ben Dooks
2022-07-12 10:08   ` Krzysztof Kozlowski
2022-07-13  9:21     ` Ben Dooks
2022-07-13  9:26       ` Krzysztof Kozlowski
2022-07-12 14:26   ` Rob Herring [this message]
2022-07-13 12:06     ` Ben Dooks
2022-07-12 22:17   ` Rob Herring
2022-07-13 11:56     ` Ben Dooks
2022-07-13 13:52       ` Uwe Kleine-König
2022-07-13 14:30         ` Ben Dooks
2022-07-13 15:07           ` Uwe Kleine-König
2022-07-13 16:20             ` Ben Dooks
2022-07-18  7:18             ` Ben Dooks
2022-07-12 10:01 ` [PATCH 4/7] pwm: dwc: allow driver to be built with COMPILE_TEST Ben Dooks
2022-07-12 10:01 ` [PATCH 5/7] pwm: dwc: add timer clock Ben Dooks
2022-07-13  6:10   ` Uwe Kleine-König
2022-07-12 10:01 ` [PATCH 6/7] pwm: dwc: remove the CONFIG_OF in " Ben Dooks
2022-07-12 10:09   ` Krzysztof Kozlowski
2022-07-12 10:20     ` Ben Dooks
2022-07-13  6:11       ` Uwe Kleine-König
2022-07-18  7:18         ` Ben Dooks
2022-07-13  9:31     ` Ben Dooks
2022-07-12 10:01 ` [PATCH 7/7] pwm: dwc: add snps,pwm-number to limit pwm count Ben Dooks
2022-07-12 10:09   ` Krzysztof Kozlowski
2022-07-18 20:08   ` Rob Herring
2022-07-19  8:20     ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1657635972.108769.1805849.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=adnan.chowdhury@sifive.com \
    --cc=ben.dooks@sifive.com \
    --cc=devicetree@vger.kernel.org \
    --cc=greentime.hu@sifive.com \
    --cc=jude.onyenegecha@sifive.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=sudip.mukherjee@sifive.com \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=william.salmon@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).