From: Rob Herring <robh@kernel.org>
To: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: linux-media@vger.kernel.org,
quentin.schulz@theobroma-systems.com,
Daniel Scally <djrscally@gmail.com>,
linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding
Date: Tue, 12 Jul 2022 16:29:35 -0600 [thread overview]
Message-ID: <1657664975.862137.2476655.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220712163349.1308540-6-tommaso.merciai@amarulasolutions.com>
On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote:
> Add documentation of device tree in YAML schema for the OV5693
> CMOS image sensor from Omnivision
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes since v1:
> - Fix allOf position as suggested by Krzysztof
> - Remove port description as suggested by Krzysztof
> - Fix EOF as suggested by Krzysztof
>
> Changes since v2:
> - Fix commit body as suggested by Krzysztof
>
> Changes since v3:
> - Add reviewed-by tags, suggested by Jacopo, Krzysztof
>
> Changes since v4:
> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari
>
> Changes since v5:
> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties
> as suggested by Jacopo
>
> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 104 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-07-12 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com>
2022-07-12 16:33 ` [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding Tommaso Merciai
2022-07-12 22:29 ` Rob Herring [this message]
2022-07-13 6:48 ` Tommaso Merciai
2022-07-13 6:52 ` Krzysztof Kozlowski
2022-07-13 13:24 ` Tommaso Merciai
2022-07-13 14:35 ` Sakari Ailus
2022-07-13 15:06 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1657664975.862137.2476655.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=mchehab@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=tommaso.merciai@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).