* [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding [not found] <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com> @ 2022-07-12 16:33 ` Tommaso Merciai 2022-07-12 22:29 ` Rob Herring 0 siblings, 1 reply; 7+ messages in thread From: Tommaso Merciai @ 2022-07-12 16:33 UTC (permalink / raw) To: tommaso.merciai Cc: linuxfancy, linux-amarula, quentin.schulz, Krzysztof Kozlowski, Daniel Scally, Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski, linux-media, devicetree, linux-kernel Add documentation of device tree in YAML schema for the OV5693 CMOS image sensor from Omnivision Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: - Fix allOf position as suggested by Krzysztof - Remove port description as suggested by Krzysztof - Fix EOF as suggested by Krzysztof Changes since v2: - Fix commit body as suggested by Krzysztof Changes since v3: - Add reviewed-by tags, suggested by Jacopo, Krzysztof Changes since v4: - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari Changes since v5: - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties as suggested by Jacopo .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml new file mode 100644 index 000000000000..8974a2c746a7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml @@ -0,0 +1,103 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2022 Amarulasolutions +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV5693 CMOS Sensor + +maintainers: + - Tommaso Merciai <tommaso.merciai@amarulasolutions.com> + +description: | + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, + sub-sampled, and windowed 10-bit MIPI images in various formats via the + Serial Camera Control Bus (SCCB) interface. + + OV5693 is controlled via I2C and two-wire Serial Camera Control Bus (SCCB). + The sensor output is available via CSI-2 serial data output (up to 2-lane). + +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + +properties: + compatible: + const: ovti,ov5693 + + reg: + maxItems: 1 + + clocks: + description: + System input clock (aka XVCLK). From 6 to 27 MHz. + maxItems: 1 + + dovdd-supply: + description: + Digital I/O voltage supply, 1.8V. + + avdd-supply: + description: + Analog voltage supply, 2.8V. + + dvdd-supply: + description: + Digital core voltage supply, 1.2V. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + This corresponds to the hardware pin XSHUTDN which is physically + active low. + maxItems: 1 + +required: + - compatible + - reg + - clocks + - port + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/px30-cru.h> + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/pinctrl/rockchip.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ov5693: camera@36 { + compatible = "ovti,ov5693"; + reg = <0x36>; + + reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&cif_clkout_m0>; + + clocks = <&cru SCLK_CIF_OUT>; + assigned-clocks = <&cru SCLK_CIF_OUT>; + assigned-clock-rates = <19200000>; + + avdd-supply = <&vcc_1v8>; + dvdd-supply = <&vcc_1v2>; + dovdd-supply = <&vcc_2v8>; + + rotation = <90>; + orientation = <0>; + + port { + ucam_out: endpoint { + remote-endpoint = <&mipi_in_ucam>; + data-lanes = <1 2>; + link-frequencies = /bits/ 64 <450000000>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 66bffb24a348..5a7881ee15e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14767,6 +14767,7 @@ M: Daniel Scally <djrscally@gmail.com> L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml F: drivers/media/i2c/ov5693.c OMNIVISION OV5695 SENSOR DRIVER -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-12 16:33 ` [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding Tommaso Merciai @ 2022-07-12 22:29 ` Rob Herring 2022-07-13 6:48 ` Tommaso Merciai 0 siblings, 1 reply; 7+ messages in thread From: Rob Herring @ 2022-07-12 22:29 UTC (permalink / raw) To: Tommaso Merciai Cc: linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: > Add documentation of device tree in YAML schema for the OV5693 > CMOS image sensor from Omnivision > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Changes since v1: > - Fix allOf position as suggested by Krzysztof > - Remove port description as suggested by Krzysztof > - Fix EOF as suggested by Krzysztof > > Changes since v2: > - Fix commit body as suggested by Krzysztof > > Changes since v3: > - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > Changes since v4: > - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > Changes since v5: > - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties > as suggested by Jacopo > > .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-12 22:29 ` Rob Herring @ 2022-07-13 6:48 ` Tommaso Merciai 2022-07-13 6:52 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Tommaso Merciai @ 2022-07-13 6:48 UTC (permalink / raw) To: Rob Herring Cc: linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Hi Rob, On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: > On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: > > Add documentation of device tree in YAML schema for the OV5693 > > CMOS image sensor from Omnivision > > > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > > - Fix allOf position as suggested by Krzysztof > > - Remove port description as suggested by Krzysztof > > - Fix EOF as suggested by Krzysztof > > > > Changes since v2: > > - Fix commit body as suggested by Krzysztof > > > > Changes since v3: > > - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > > > Changes since v4: > > - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > > > Changes since v5: > > - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties > > as suggested by Jacopo > > > > .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > I run: pip3 install dtschema --upgrade Then I check .yaml using: make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts LINT Documentation/devicetree/bindings CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb No error on my side. I'm missing something? Let me know. Thanks, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-13 6:48 ` Tommaso Merciai @ 2022-07-13 6:52 ` Krzysztof Kozlowski 2022-07-13 13:24 ` Tommaso Merciai 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-07-13 6:52 UTC (permalink / raw) To: Tommaso Merciai, Rob Herring Cc: linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On 13/07/2022 08:48, Tommaso Merciai wrote: > Hi Rob, > > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: >>> Add documentation of device tree in YAML schema for the OV5693 >>> CMOS image sensor from Omnivision >>> >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Changes since v1: >>> - Fix allOf position as suggested by Krzysztof >>> - Remove port description as suggested by Krzysztof >>> - Fix EOF as suggested by Krzysztof >>> >>> Changes since v2: >>> - Fix commit body as suggested by Krzysztof >>> >>> Changes since v3: >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof >>> >>> Changes since v4: >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari >>> >>> Changes since v5: >>> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties >>> as suggested by Jacopo >>> >>> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 104 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/patch/ >> >> This check can fail if there are any dependencies. The base for a patch >> series is generally the most recent rc1. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. >> > > I run: > > pip3 install dtschema --upgrade > > Then I check .yaml using: > > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > No error on my side. I'm missing something? Rob's check are running newer dtschema, from master branch. The error he reports is about missing port, although I thought it is coming from video-interface-devices. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-13 6:52 ` Krzysztof Kozlowski @ 2022-07-13 13:24 ` Tommaso Merciai 2022-07-13 14:35 ` Sakari Ailus 0 siblings, 1 reply; 7+ messages in thread From: Tommaso Merciai @ 2022-07-13 13:24 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel On Wed, Jul 13, 2022 at 08:52:34AM +0200, Krzysztof Kozlowski wrote: > On 13/07/2022 08:48, Tommaso Merciai wrote: > > Hi Rob, > > > > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: > >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: > >>> Add documentation of device tree in YAML schema for the OV5693 > >>> CMOS image sensor from Omnivision > >>> > >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> --- > >>> Changes since v1: > >>> - Fix allOf position as suggested by Krzysztof > >>> - Remove port description as suggested by Krzysztof > >>> - Fix EOF as suggested by Krzysztof > >>> > >>> Changes since v2: > >>> - Fix commit body as suggested by Krzysztof > >>> > >>> Changes since v3: > >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof > >>> > >>> Changes since v4: > >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > >>> > >>> Changes since v5: > >>> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties > >>> as suggested by Jacopo > >>> > >>> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ > >>> MAINTAINERS | 1 + > >>> 2 files changed, 104 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > >> > >> doc reference errors (make refcheckdocs): > >> > >> See https://patchwork.ozlabs.org/patch/ > >> > >> This check can fail if there are any dependencies. The base for a patch > >> series is generally the most recent rc1. > >> > >> If you already ran 'make dt_binding_check' and didn't see the above > >> error(s), then make sure 'yamllint' is installed and dt-schema is up to > >> date: > >> > >> pip3 install dtschema --upgrade > >> > >> Please check and re-submit. > >> > > > > I run: > > > > pip3 install dtschema --upgrade > > > > Then I check .yaml using: > > > > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts > > LINT Documentation/devicetree/bindings > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > > > No error on my side. I'm missing something? > > Rob's check are running newer dtschema, from master branch. The error he > reports is about missing port, although I thought it is coming from > video-interface-devices. Hi Krzysztof, Thanks for the info! :) Regards, Tommaso > > Best regards, > Krzysztof -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-13 13:24 ` Tommaso Merciai @ 2022-07-13 14:35 ` Sakari Ailus 2022-07-13 15:06 ` Tommaso Merciai 0 siblings, 1 reply; 7+ messages in thread From: Sakari Ailus @ 2022-07-13 14:35 UTC (permalink / raw) To: Tommaso Merciai Cc: Krzysztof Kozlowski, Rob Herring, linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Hi Tommaso, Krzysztof, On Wed, Jul 13, 2022 at 03:24:51PM +0200, Tommaso Merciai wrote: > On Wed, Jul 13, 2022 at 08:52:34AM +0200, Krzysztof Kozlowski wrote: > > On 13/07/2022 08:48, Tommaso Merciai wrote: > > > Hi Rob, > > > > > > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: > > >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: > > >>> Add documentation of device tree in YAML schema for the OV5693 > > >>> CMOS image sensor from Omnivision > > >>> > > >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > >>> --- > > >>> Changes since v1: > > >>> - Fix allOf position as suggested by Krzysztof > > >>> - Remove port description as suggested by Krzysztof > > >>> - Fix EOF as suggested by Krzysztof > > >>> > > >>> Changes since v2: > > >>> - Fix commit body as suggested by Krzysztof > > >>> > > >>> Changes since v3: > > >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > >>> > > >>> Changes since v4: > > >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > >>> > > >>> Changes since v5: > > >>> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties > > >>> as suggested by Jacopo > > >>> > > >>> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ > > >>> MAINTAINERS | 1 + > > >>> 2 files changed, 104 insertions(+) > > >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > >>> > > >> > > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > >> > > >> yamllint warnings/errors: > > >> > > >> dtschema/dtc warnings/errors: > > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) > > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > >> > > >> doc reference errors (make refcheckdocs): > > >> > > >> See https://patchwork.ozlabs.org/patch/ > > >> > > >> This check can fail if there are any dependencies. The base for a patch > > >> series is generally the most recent rc1. > > >> > > >> If you already ran 'make dt_binding_check' and didn't see the above > > >> error(s), then make sure 'yamllint' is installed and dt-schema is up to > > >> date: > > >> > > >> pip3 install dtschema --upgrade > > >> > > >> Please check and re-submit. > > >> > > > > > > I run: > > > > > > pip3 install dtschema --upgrade > > > > > > Then I check .yaml using: > > > > > > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts > > > LINT Documentation/devicetree/bindings > > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > > CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > > > > > No error on my side. I'm missing something? > > > > Rob's check are running newer dtschema, from master branch. The error he > > reports is about missing port, although I thought it is coming from > > video-interface-devices. > > Hi Krzysztof, > Thanks for the info! :) These bindings are indeed missing the port node, please add one. See e.g. Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml for an example. The reason why video-interfaces and video-interface-device are sparate is because they deal with different nodes (device vs. port). -- Kind regards, Sakari Ailus ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding 2022-07-13 14:35 ` Sakari Ailus @ 2022-07-13 15:06 ` Tommaso Merciai 0 siblings, 0 replies; 7+ messages in thread From: Tommaso Merciai @ 2022-07-13 15:06 UTC (permalink / raw) To: Sakari Ailus Cc: Krzysztof Kozlowski, Rob Herring, linux-media, quentin.schulz, Daniel Scally, linuxfancy, linux-amarula, Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel Hi Sakari, On Wed, Jul 13, 2022 at 05:35:40PM +0300, Sakari Ailus wrote: > Hi Tommaso, Krzysztof, > > On Wed, Jul 13, 2022 at 03:24:51PM +0200, Tommaso Merciai wrote: > > On Wed, Jul 13, 2022 at 08:52:34AM +0200, Krzysztof Kozlowski wrote: > > > On 13/07/2022 08:48, Tommaso Merciai wrote: > > > > Hi Rob, > > > > > > > > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: > > > >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: > > > >>> Add documentation of device tree in YAML schema for the OV5693 > > > >>> CMOS image sensor from Omnivision > > > >>> > > > >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > > > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > >>> --- > > > >>> Changes since v1: > > > >>> - Fix allOf position as suggested by Krzysztof > > > >>> - Remove port description as suggested by Krzysztof > > > >>> - Fix EOF as suggested by Krzysztof > > > >>> > > > >>> Changes since v2: > > > >>> - Fix commit body as suggested by Krzysztof > > > >>> > > > >>> Changes since v3: > > > >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > > >>> > > > >>> Changes since v4: > > > >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > > >>> > > > >>> Changes since v5: > > > >>> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties > > > >>> as suggested by Jacopo > > > >>> > > > >>> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ > > > >>> MAINTAINERS | 1 + > > > >>> 2 files changed, 104 insertions(+) > > > >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > >>> > > > >> > > > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > >> > > > >> yamllint warnings/errors: > > > >> > > > >> dtschema/dtc warnings/errors: > > > >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) > > > >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > >> > > > >> doc reference errors (make refcheckdocs): > > > >> > > > >> See https://patchwork.ozlabs.org/patch/ > > > >> > > > >> This check can fail if there are any dependencies. The base for a patch > > > >> series is generally the most recent rc1. > > > >> > > > >> If you already ran 'make dt_binding_check' and didn't see the above > > > >> error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > >> date: > > > >> > > > >> pip3 install dtschema --upgrade > > > >> > > > >> Please check and re-submit. > > > >> > > > > > > > > I run: > > > > > > > > pip3 install dtschema --upgrade > > > > > > > > Then I check .yaml using: > > > > > > > > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts > > > > LINT Documentation/devicetree/bindings > > > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > > DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > > > CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > > > > > > > No error on my side. I'm missing something? > > > > > > Rob's check are running newer dtschema, from master branch. The error he > > > reports is about missing port, although I thought it is coming from > > > video-interface-devices. > > > > Hi Krzysztof, > > Thanks for the info! :) > > These bindings are indeed missing the port node, please add one. See e.g. > Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml for an > example. > > The reason why video-interfaces and video-interface-device are sparate is > because they deal with different nodes (device vs. port). Thanks, sent v7. Tommaso > > -- > Kind regards, > > Sakari Ailus -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-13 15:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220712163349.1308540-1-tommaso.merciai@amarulasolutions.com>
2022-07-12 16:33 ` [PATCH v6 5/6] media: dt-bindings: ov5693: document YAML binding Tommaso Merciai
2022-07-12 22:29 ` Rob Herring
2022-07-13 6:48 ` Tommaso Merciai
2022-07-13 6:52 ` Krzysztof Kozlowski
2022-07-13 13:24 ` Tommaso Merciai
2022-07-13 14:35 ` Sakari Ailus
2022-07-13 15:06 ` Tommaso Merciai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).