From: Kris Bahnsen <kris@embeddedTS.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Mark Featherston <mark@embeddedTS.com>
Subject: Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support
Date: Tue, 19 Jul 2022 10:39:14 -0700 [thread overview]
Message-ID: <1658252354.3157.1.camel@embeddedTS.com> (raw)
In-Reply-To: <add23ad7-2539-cef3-8684-10ec8e680483@linaro.org>
On Mon, 2022-07-18 at 14:49 +0200, Krzysztof Kozlowski wrote:
> On 15/07/2022 19:54, Kris Bahnsen wrote:
> > On Fri, 2022-07-15 at 08:42 +0200, Krzysztof Kozlowski wrote:
> > > On 14/07/2022 23:26, Kris Bahnsen wrote:
> > > > On Thu, 2022-07-14 at 10:34 +0200, Krzysztof Kozlowski wrote:
> > > > > On 14/07/2022 00:12, Kris Bahnsen wrote:
> > > > > > Add initial support of the i.MX6UL based TS-7553-V2 platform.
> > > > >
> > > > > Use subject prefix matching the subsystem. git log --oneline --
> > > >
> > > > Can you please elaborate? The subject prefix is "ARM: dts:", I'm not
> > > > sure what is missing. Should it be something like
> > > > "ARM: dts: imx6ul-ts7553v2:" in this case?
> > >
> > > Run the command, you will see.
> >
> > I had previously run the command and the output of it did not make sense in
> > the context of your prior comment. Forgive my ignorance, but I'd like to
> > understand specifically what you mean here so we can do the correct thing
> > in the future.
> >
> > $ git log --oneline -- | head -n 20
>
> This obviously does not make sense. -- as you can read in git log help
> and several other Unix/Linux commands is marking path arguments. You
> want to run it on specific subsystem, don't you?
I've looked at commits for imx6ul-* devicetree files and that was how
I derived this commit/subject. I see a number of different patterns
and if one is preferred over the other I would appreciate the
clarification.
e.g. looking at commits of imx6ul-*
"ARM: dts:" is used for a number of initial devicetree commits
"ARM: dts: imx6ul: <board>:" is used a few times
"ARM: dts: imx6ul-<board>:" is also used a few times
For initial commits of a devicetree, or modifications of a devicetree,
what is the preferred pattern moving forward?
Thank you for your continued support.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-07-19 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 22:12 [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support Kris Bahnsen
2022-07-14 8:34 ` Krzysztof Kozlowski
2022-07-14 21:26 ` Kris Bahnsen
2022-07-15 6:42 ` Krzysztof Kozlowski
2022-07-15 17:54 ` Kris Bahnsen
2022-07-18 12:49 ` Krzysztof Kozlowski
2022-07-19 17:39 ` Kris Bahnsen [this message]
2022-07-19 19:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658252354.3157.1.camel@embeddedTS.com \
--to=kris@embeddedts.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@embeddedTS.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).