From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: linux-rtc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v3 1/1] dt-bindings: rtc: nxp,pcf85063: Convert to DT schema
Date: Mon, 25 Jul 2022 07:36:42 -0600 [thread overview]
Message-ID: <1658756202.615935.1989014.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220725071919.25342-1-alexander.stein@ew.tq-group.com>
On Mon, 25 Jul 2022 09:19:19 +0200, Alexander Stein wrote:
> Convert the NXP PCF85063 RTC binding to DT schema format.
>
> Add 'interrupts' and 'wakeup-source' as this device has an interrupt
> which was not documented, but is in use.
> 'clock-output-names' and '#clock-cells' are added as well, those were
> probably missed when adding clkout support in commit 8c229ab6048b
> ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Krzysztof, thanks for your review.
>
> Changes in v3:
> * Added constraints for rv8263 & pcf85063 regarding 'quartz-load-femtofarads'
> * Fixed example
>
> I have to admit I could not actually verify in the registers that pcf85063 is
> limited to 7pF. I was not able to find any datasheet containg the registers,
> only a product brief [1] indicating this limit.
>
> Changes in v2:
> * Sorted compatible list
> * Mentioned new #clock-cells and clock-output-names properties in commit message
> * Removed 'interrupt-names', not needed/used anyway
> * Fixed quartz-load-femtofarads defintion/description
>
> [1] https://www.mouser.de/pdfDocs/NXP_PCF85063_PB.pdf
>
> .../devicetree/bindings/rtc/nxp,pcf85063.txt | 32 -------
> .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 92 +++++++++++++++++++
> 2 files changed, 92 insertions(+), 32 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt
> create mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
rtc@51: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb
rtc@51: quartz-load-femtofarads:0:0: 7000 was expected
arch/arm/boot/dts/imx6dl-skov-revc-lt2.dtb
arch/arm/boot/dts/imx6dl-skov-revc-lt6.dtb
arch/arm/boot/dts/imx6q-skov-revc-lt2.dtb
arch/arm/boot/dts/imx6q-skov-revc-lt6.dtb
arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dtb
next prev parent reply other threads:[~2022-07-25 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 7:19 [PATCH v3 1/1] dt-bindings: rtc: nxp,pcf85063: Convert to DT schema Alexander Stein
2022-07-25 13:36 ` Rob Herring [this message]
2022-07-25 14:09 ` [PATCH v3 1/1] dt-bindings: rtc: nxp, pcf85063: " Alexander Stein
2022-07-25 16:26 ` [PATCH v3 1/1] dt-bindings: rtc: nxp,pcf85063: " Krzysztof Kozlowski
2022-07-26 15:00 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658756202.615935.1989014.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexander.stein@ew.tq-group.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).