devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Matt Ranostay <mranostay@ti.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, lee@kernel.org, nm@ti.com,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/4] Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC
Date: Fri, 05 Aug 2022 08:14:55 -0600	[thread overview]
Message-ID: <1659708895.345431.1809602.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220805064352.793918-2-mranostay@ti.com>

On Thu, 04 Aug 2022 23:43:49 -0700, Matt Ranostay wrote:
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti,tps6594x.yaml  | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml: properties:ti,system-power-controller: 'oneOf' conditional failed, one must be fixed:
	'type' is a required property
		hint: A vendor boolean property can use "type: boolean"
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml: properties:ti,system-power-controller: 'oneOf' conditional failed, one must be fixed:
		'enum' is a required property
		'const' is a required property
		hint: A vendor string property with exact values has an implicit type
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml: properties:ti,system-power-controller: 'oneOf' conditional failed, one must be fixed:
		'$ref' is a required property
		'allOf' is a required property
		hint: A vendor property needs a $ref to types.yaml
		from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
./Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml: $id: relative path/filename doesn't match actual path or filename
	expected: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml: ignoring, error in schema: properties: ti,system-power-controller
Documentation/devicetree/bindings/mfd/ti,tps6594x.example.dtb:0:0: /example-0/i2c0/pmic@48: failed to match any schema with compatible: ['ti,tps6594x']
Documentation/devicetree/bindings/mfd/ti,tps6594x.example.dtb:0:0: /example-0/i2c0/pmic@48/rtc: failed to match any schema with compatible: ['ti,tps6594x-rtc']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2022-08-05 14:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  6:43 [PATCH 0/4] mfd: add tps6594x support for j7200 platform Matt Ranostay
2022-08-05  6:43 ` [PATCH 1/4] Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC Matt Ranostay
2022-08-05 14:14   ` Rob Herring [this message]
2022-08-05  6:43 ` [PATCH 2/4] MFD: TPS6594x: Add new mfd device for " Matt Ranostay
2022-08-10 11:27   ` Lee Jones
2022-08-11  6:33     ` Matt Ranostay
2022-08-11  7:04       ` Lee Jones
2022-08-05  6:43 ` [PATCH 3/4] rtc: rtc-tps6594x: Add support for TPS6594X PMIC RTC Matt Ranostay
2022-08-05  6:43 ` [PATCH 4/4] arm64: dts: ti: k3-j7200-common-proc-board: Add TPS6594x PMIC node Matt Ranostay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1659708895.345431.1809602.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mranostay@ti.com \
    --cc=nm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).