* [RESEND PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node
2022-08-10 5:05 [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Satya Priya
@ 2022-08-10 5:05 ` Satya Priya
2022-08-10 22:58 ` Stephen Boyd
2022-08-10 5:05 ` [RESEND PATCH V4 2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Satya Priya
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Satya Priya @ 2022-08-10 5:05 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Douglas Anderson, Stephen Boyd, Andy Gross, devicetree,
linux-arm-msm, linux-kernel, quic_tdas, quic_c_skakit
Remove "cc" regmap from lpasscc node which is overlapping
with the lpass_aon regmap.
Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
Changes since v4:
- Fix tabbing.
Changes since v3:
- None.
Changes since v2:
- Cleanup the lpasscc node to handle regmap overlap with lpass_aon
instead of disabling the lpasscc node.
- This patch is added in v3.
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 13d7f26..ca76310 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2168,9 +2168,8 @@
lpasscc: lpasscc@3000000 {
compatible = "qcom,sc7280-lpasscc";
reg = <0 0x03000000 0 0x40>,
- <0 0x03c04000 0 0x4>,
- <0 0x03389000 0 0x24>;
- reg-names = "qdsp6ss", "top_cc", "cc";
+ <0 0x03c04000 0 0x4>;
+ reg-names = "qdsp6ss", "top_cc";
clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
clock-names = "iface";
#clock-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RESEND PATCH V4 2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
2022-08-10 5:05 [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Satya Priya
2022-08-10 5:05 ` [RESEND PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node Satya Priya
@ 2022-08-10 5:05 ` Satya Priya
2022-08-10 5:05 ` [RESEND PATCH V4 3/3] arm64: dts: qcom: sc7280: Update lpasscore node Satya Priya
2022-08-29 23:46 ` [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Satya Priya @ 2022-08-10 5:05 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Douglas Anderson, Stephen Boyd, Andy Gross, devicetree,
linux-arm-msm, linux-kernel, quic_tdas, quic_c_skakit
From: Taniya Das <quic_tdas@quicinc.com>
The lpass audio supports TX/RX/WSA block resets.
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes since v4:
- None.
Changes since v3:
- Move the lpasscore node update to separate patch.
Changes since v2:
- Remove the status="disabled" from lpasscc node.
arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index ca76310..4652f28 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2184,6 +2184,7 @@
power-domains = <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
#clock-cells = <1>;
#power-domain-cells = <1>;
+ #reset-cells = <1>;
};
lpass_aon: clock-controller@3380000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RESEND PATCH V4 3/3] arm64: dts: qcom: sc7280: Update lpasscore node
2022-08-10 5:05 [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Satya Priya
2022-08-10 5:05 ` [RESEND PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node Satya Priya
2022-08-10 5:05 ` [RESEND PATCH V4 2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets Satya Priya
@ 2022-08-10 5:05 ` Satya Priya
2022-08-29 23:46 ` [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Satya Priya @ 2022-08-10 5:05 UTC (permalink / raw)
To: Rob Herring, Bjorn Andersson
Cc: Douglas Anderson, Stephen Boyd, Andy Gross, devicetree,
linux-arm-msm, linux-kernel, quic_tdas, quic_c_skakit
To maintain consistency with other lpass nodes(lpass_audiocc,
lpass_aon and lpass_hm), update lpasscore to lpass_core.
Fixes: 9499240d15f2 ("arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers")
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
Changes since v4:
- None.
Changes since v3:
- This is newly added in v4, inorder to update the lpasscore node in a
separate patch.
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 4652f28..880217c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2192,13 +2192,13 @@
reg = <0 0x03380000 0 0x30000>;
clocks = <&rpmhcc RPMH_CXO_CLK>,
<&rpmhcc RPMH_CXO_CLK_A>,
- <&lpasscore LPASS_CORE_CC_CORE_CLK>;
+ <&lpass_core LPASS_CORE_CC_CORE_CLK>;
clock-names = "bi_tcxo", "bi_tcxo_ao", "iface";
#clock-cells = <1>;
#power-domain-cells = <1>;
};
- lpasscore: clock-controller@3900000 {
+ lpass_core: clock-controller@3900000 {
compatible = "qcom,sc7280-lpasscorecc";
reg = <0 0x03900000 0 0x50000>;
clocks = <&rpmhcc RPMH_CXO_CLK>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280
2022-08-10 5:05 [RESEND PATCH V4 0/3] Add DT support for audio clock gating resets for SC7280 Satya Priya
` (2 preceding siblings ...)
2022-08-10 5:05 ` [RESEND PATCH V4 3/3] arm64: dts: qcom: sc7280: Update lpasscore node Satya Priya
@ 2022-08-29 23:46 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-08-29 23:46 UTC (permalink / raw)
To: quic_c_skakit, Bjorn Andersson, robh
Cc: dianders, linux-arm-msm, swboyd, linux-kernel, quic_tdas,
devicetree, agross
On Wed, 10 Aug 2022 10:35:06 +0530, Satya Priya wrote:
> This series depends on [1], which adds the dt-binding changes.
>
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=663372
>
> Satya Priya (2):
> arm64: dts: qcom: sc7280: Cleanup the lpasscc node
> arm64: dts: qcom: sc7280: Update lpasscore node
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node
commit: 8c7ebabd2e3f33ef24378d3cac00d3e59886cecb
[2/3] arm64: dts: qcom: sc7280: Update lpassaudio clock controller for resets
commit: e02a16c23410a118e5497601871a2f8c3ea9bfd0
[3/3] arm64: dts: qcom: sc7280: Update lpasscore node
commit: d9a1e922730389afc425f2250de361b7f07acdbc
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread