From: Rob Herring <robh@kernel.org>
To: Elliot Berman <quic_eberman@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Carl van Schaik <quic_cvanscha@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
Trilok Soni <quic_tsoni@quicinc.com>,
Andy Gross <agross@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Murali Nalajala <quic_mnalajal@quicinc.com>,
Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>,
devicetree@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-doc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v3 03/12] dt-bindings: Add binding for gunyah hypervisor
Date: Fri, 12 Aug 2022 09:13:53 -0600 [thread overview]
Message-ID: <1660317233.437369.168979.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220811214107.1074343-4-quic_eberman@quicinc.com>
On Thu, 11 Aug 2022 14:40:58 -0700, Elliot Berman wrote:
> When Linux is booted as a guest under the Gunyah hypervisor, the Gunyah
> Resource Manager applies a devicetree overlay describing the virtual
> platform configuration of the guest VM, such as the message queue
> capability IDs for communicating with the Resource Manager. This
> information is not otherwise discoverable by a VM: the Gunyah hypervisor
> core does not provide a direct interface to discover capability IDs nor
> a way to communicate with RM without having already known the
> corresponding message queue capability ID. Add the DT bindings that
> Gunyah adheres for the hypervisor node and message queues.
>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> ---
> Changes since v2:
> - Add newlines as suggested
> - Fixed typo in example (gunyah-resource-mgr@0 -> gunyah-resource-mgr@1)
>
> .../bindings/firmware/gunyah-hypervisor.yaml | 87 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 88 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml: properties:compatible: [{'items': [{'const': 'gunyah-hypervisor-1.0'}, {'const': 'gunyah-hypervisor'}]}] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml: patternProperties:^gunyah-resource-mgr(@.*)?:properties:compatible: [{'items': [{'const': 'gunyah-resource-manager-1-0'}, {'const': 'gunyah-resource-manager'}]}] is not of type 'object', 'boolean'
from schema $id: http://json-schema.org/draft-07/schema#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/gunyah-hypervisor.yaml: ignoring, error in schema: properties: compatible
Documentation/devicetree/bindings/firmware/gunyah-hypervisor.example.dtb:0:0: /example-0/hypervisor: failed to match any schema with compatible: ['gunyah-hypervisor-1.0', 'gunyah-hypervisor']
Documentation/devicetree/bindings/firmware/gunyah-hypervisor.example.dtb:0:0: /example-0/hypervisor: failed to match any schema with compatible: ['gunyah-hypervisor-1.0', 'gunyah-hypervisor']
Documentation/devicetree/bindings/firmware/gunyah-hypervisor.example.dtb:0:0: /example-0/hypervisor/gunyah-resource-mgr@0: failed to match any schema with compatible: ['gunyah-resource-manager-1-0', 'gunyah-resource-manager']
Documentation/devicetree/bindings/firmware/gunyah-hypervisor.example.dtb:0:0: /example-0/hypervisor/gunyah-resource-mgr@0: failed to match any schema with compatible: ['gunyah-resource-manager-1-0', 'gunyah-resource-manager']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-08-12 15:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 21:40 [PATCH v3 00/12] Drivers for gunyah hypervisor Elliot Berman
2022-08-11 21:40 ` [PATCH v3 01/12] arm64: smccc: Include alternative-macros.h Elliot Berman
2022-08-11 21:40 ` [PATCH v3 02/12] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman
2022-08-12 8:25 ` Bagas Sanjaya
2022-08-11 21:40 ` [PATCH v3 03/12] dt-bindings: Add binding for gunyah hypervisor Elliot Berman
2022-08-12 15:13 ` Rob Herring [this message]
2022-08-11 21:40 ` [PATCH v3 04/12] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman
2022-08-11 21:41 ` [PATCH v3 05/12] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman
2022-08-11 21:41 ` [PATCH v3 06/12] virt: gunyah: Add sysfs nodes Elliot Berman
2022-08-23 8:06 ` Dmitry Baryshkov
2022-08-11 21:41 ` [PATCH v3 07/12] gunyah: msgq: Add Gunyah message queues Elliot Berman
2022-08-11 21:41 ` [PATCH v3 08/12] gunyah: sysfs: Add node to describe supported features Elliot Berman
2022-08-11 21:41 ` [PATCH v3 09/12] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman
2022-08-11 21:41 ` [PATCH v3 10/12] gunyah: rsc_mgr: Add RPC for console services Elliot Berman
2022-08-11 21:41 ` [PATCH v3 11/12] gunyah: rsc_mgr: Add auxiliary devices for console Elliot Berman
2022-08-11 21:41 ` [PATCH v3 12/12] tty: gunyah: Add tty console driver for RM Console Serivces Elliot Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660317233.437369.168979.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=quic_cvanscha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).