From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
arm-soc <arm@kernel.org>,
Device Tree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 08/12] dt-bindings: nand-controller: Reflect reality of marvell,orion-nand
Date: Thu, 25 Aug 2022 06:58:57 -0500 [thread overview]
Message-ID: <1661428737.531900.263760.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220825013258.3459714-9-andrew@lunn.ch>
On Thu, 25 Aug 2022 03:32:54 +0200, Andrew Lunn wrote:
> The Marvell Orion NAND driver comes from before the time of the
> standardised NAND binding. The controller only supports a single
> device, and expects the NAND partition table to be directly in the
> controller node. This goes against the standardised NAND binding which
> expects a sub node per NAND device, which contains the partition
> table.
>
> Since the partition table contains a reg property indicating the start
> address of the partition and its length, it needs #size-cells set to
> 1. However, for a list of nand devices, the reg value is the device
> number, requiring #size-cells of 0.
>
> Add an exception to nand-controller.yaml to allow this #size-cells
> value when the compatible matches the orion controller.
>
> In order that the example works, it needs a compatible string so the
> comparison can be made. Pick the first example in the directory.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> .../bindings/mtd/nand-controller.yaml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/nand-controller.example.dtb: nand-controller: 'reg' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/arm,pl353-nand-r2p1.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-08-25 11:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 1:32 [PATCH v2 00/12] Start converting MVEBU bindings to DT Schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 01/12] dt-bindings: RTC: orion-rtc: Convert to DT schema Andrew Lunn
2022-08-30 18:31 ` Rob Herring
2022-08-25 1:32 ` [PATCH v2 02/12] dt-bindings: thermal: marvell,kirkwood-thermal: " Andrew Lunn
2022-08-30 18:35 ` Rob Herring
2022-08-25 1:32 ` [PATCH v2 03/12] dt-bindings: pinctrl: Convert marvell,kirkwood-pintctrl " Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 04/12] dt-bindings: marvell,ac5-pinctrl: Refactor to look like other Marvell pinctrl files Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 05/12] dt-bindings: USB: Convert ehci-orion to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 06/12] dt-bindings: watchdog: Convert marvel.txt " Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 07/12] arm: DT: kirkwood/orion5: Rename watchdog node Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 08/12] dt-bindings: nand-controller: Reflect reality of marvell,orion-nand Andrew Lunn
2022-08-25 11:58 ` Rob Herring [this message]
2022-08-25 1:32 ` [PATCH v2 09/12] dt-bindings: mtd: Convert orion-nand to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 10/12] arm: DT: kirkwood.dtsi: Rename nand to nand-controller Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 11/12] dt-bindings: timer: Convert marvell,orion-timer.txt to DT schema Andrew Lunn
2022-08-25 1:32 ` [PATCH v2 12/12] dt-bindings: clock: Convert mvebu-gated-clock.txt " Andrew Lunn
2022-08-30 18:43 ` [PATCH v2 00/12] Start converting MVEBU bindings to DT Schema Rob Herring
2022-08-30 19:22 ` Andrew Lunn
2022-08-31 19:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1661428737.531900.263760.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).