From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: kw@linux.com, andersson@kernel.org, linux-kernel@vger.kernel.org,
lpieralisi@kernel.org, dmitry.baryshkov@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
konrad.dybcio@somainline.org, linux-pci@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
bhelgaas@google.com
Subject: Re: [PATCH v2 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform
Date: Wed, 31 Aug 2022 06:39:21 -0500 [thread overview]
Message-ID: <1661945961.468486.3614525.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220830165817.183571-10-manivannan.sadhasivam@linaro.org>
On Tue, 30 Aug 2022 22:28:15 +0530, Manivannan Sadhasivam wrote:
> In preparation of adding the bindings for future SoCs, let's define the
> clocks per platform.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/pci/qcom,pcie-ep.yaml | 51 ++++++++++++-------
> 1 file changed, 32 insertions(+), 19 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml: allOf:1:then:properties:clocks: {'maxItems': 7, 'items': [{'description': 'PCIe Auxiliary clock'}, {'description': 'PCIe CFG AHB clock'}, {'description': 'PCIe Master AXI clock'}, {'description': 'PCIe Slave AXI clock'}, {'description': 'PCIe Slave Q2A AXI clock'}, {'description': 'PCIe Sleep clock'}, {'description': 'PCIe Reference clock'}]} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml: ignoring, error in schema: allOf: 1: then: properties: clocks
Documentation/devicetree/bindings/pci/qcom,pcie-ep.example.dtb:0:0: /example-0/pcie-ep@40000000: failed to match any schema with compatible: ['qcom,sdx55-pcie-ep']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2022-08-31 11:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 16:58 [PATCH v2 00/11] Improvements to the Qcom PCIe Endpoint driver Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 01/11] PCI: qcom-ep: Add kernel-doc for qcom_pcie_ep structure Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 02/11] PCI: qcom-ep: Do not use hardcoded clks in driver Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 03/11] PCI: qcom-ep: Make use of the cached dev pointer Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 04/11] PCI: qcom-ep: Add eDMA support Manivannan Sadhasivam
2022-09-03 2:36 ` kernel test robot
2022-09-10 5:32 ` Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 05/11] PCI: qcom-ep: Disable IRQs during driver remove Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 06/11] PCI: qcom-ep: Add debugfs support for expose link transition counts Manivannan Sadhasivam
2022-08-30 19:51 ` Bjorn Helgaas
2022-08-30 16:58 ` [PATCH v2 07/11] dt-bindings: PCI: qcom-ep: Make PERST separation optional Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 08/11] " Manivannan Sadhasivam
2022-08-30 16:58 ` [PATCH v2 09/11] dt-bindings: PCI: qcom-ep: Define clocks per platform Manivannan Sadhasivam
2022-08-30 18:40 ` Krzysztof Kozlowski
2022-08-31 11:39 ` Rob Herring [this message]
2022-08-30 16:58 ` [PATCH v2 10/11] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC Manivannan Sadhasivam
2022-08-30 18:41 ` Krzysztof Kozlowski
2022-08-30 16:58 ` [PATCH v2 11/11] " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1661945961.468486.3614525.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).