devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: dt-bindings: audio-graph-card2: add missing {hp/mic}-det-gpios
@ 2025-05-12  2:36 Kuninori Morimoto
  2025-05-12 10:46 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2025-05-12  2:36 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, Krzysztof Kozlowski; +Cc: linux-sound, devicetree

The yaml has "hp-det-gpios" property, but Audio-Graph-Card2 can handle
"hp-det-gpio", "mic-det-gpios", "mic-det-gpio" too.
Add these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 .../devicetree/bindings/sound/audio-graph-card2.yaml        | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
index 94588353f852a..77c21733f9e63 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
@@ -39,6 +39,12 @@ properties:
     description: Codec to Codec node
   hp-det-gpios:
     $ref: audio-graph.yaml#/properties/hp-det-gpios
+  hp-det-gpio:
+    $ref: audio-graph.yaml#/properties/hp-det-gpio
+  mic-det-gpios:
+    $ref: audio-graph.yaml#/properties/mic-det-gpios
+  mic-det-gpio:
+    $ref: audio-graph.yaml#/properties/mic-det-gpio
   widgets:
     $ref: audio-graph.yaml#/properties/widgets
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: dt-bindings: audio-graph-card2: add missing {hp/mic}-det-gpios
  2025-05-12  2:36 [PATCH] ASoC: dt-bindings: audio-graph-card2: add missing {hp/mic}-det-gpios Kuninori Morimoto
@ 2025-05-12 10:46 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-12 10:46 UTC (permalink / raw)
  To: Kuninori Morimoto, Mark Brown, Rob Herring, Krzysztof Kozlowski
  Cc: linux-sound, devicetree

On 12/05/2025 04:36, Kuninori Morimoto wrote:
> The yaml has "hp-det-gpios" property, but Audio-Graph-Card2 can handle
> "hp-det-gpio", "mic-det-gpios", "mic-det-gpio" too.
> Add these.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  .../devicetree/bindings/sound/audio-graph-card2.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> index 94588353f852a..77c21733f9e63 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
> @@ -39,6 +39,12 @@ properties:
>      description: Codec to Codec node
>    hp-det-gpios:
>      $ref: audio-graph.yaml#/properties/hp-det-gpios
> +  hp-det-gpio:
> +    $ref: audio-graph.yaml#/properties/hp-det-gpio

Same comments as for your v1 (and this is v2? please version your
patches correctly or use RESEND).

Drop, redundant.

> +  mic-det-gpios:
> +    $ref: audio-graph.yaml#/properties/mic-det-gpios
> +  mic-det-gpio:

Drop

> +    $ref: audio-graph.yaml#/properties/mic-det-gpio
>    widgets:
>      $ref: audio-graph.yaml#/properties/widgets
>  


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-05-12 10:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-12  2:36 [PATCH] ASoC: dt-bindings: audio-graph-card2: add missing {hp/mic}-det-gpios Kuninori Morimoto
2025-05-12 10:46 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).