* [PATCH net-next 0/2] net: lan966x: make reset optional
@ 2022-08-31 11:18 Michael Walle
2022-08-31 11:18 ` [PATCH net-next 1/2] dt-bindings: net: sparx5: don't require a reset line Michael Walle
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Michael Walle @ 2022-08-31 11:18 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Lars Povlsen, Steen Hegelund,
Horatiu Vultur
Cc: UNGLinuxDriver, Philipp Zabel, netdev, devicetree,
linux-arm-kernel, linux-kernel, Michael Walle
This is the remaining part of the reset rework on the LAN966x targetting
the netdev tree.
The former series can be found at:
https://lore.kernel.org/lkml/20220826115607.1148489-1-michael@walle.cc/
Michael Walle (2):
dt-bindings: net: sparx5: don't require a reset line
net: lan966x: make reset optional
.../devicetree/bindings/net/microchip,sparx5-switch.yaml | 2 --
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] dt-bindings: net: sparx5: don't require a reset line
2022-08-31 11:18 [PATCH net-next 0/2] net: lan966x: make reset optional Michael Walle
@ 2022-08-31 11:18 ` Michael Walle
2022-08-31 11:18 ` [PATCH net-next 2/2] net: lan966x: make reset optional Michael Walle
2022-09-02 11:30 ` [PATCH net-next 0/2] " patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-08-31 11:18 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Lars Povlsen, Steen Hegelund,
Horatiu Vultur
Cc: UNGLinuxDriver, Philipp Zabel, netdev, devicetree,
linux-arm-kernel, linux-kernel, Michael Walle,
Krzysztof Kozlowski
Make the reset line optional. It turns out, there is no dedicated reset
for the switch. Instead, the reset which was used up until now, was kind
of a global reset. This is now handled elsewhere, thus don't require a
reset.
Signed-off-by: Michael Walle <michael@walle.cc>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/net/microchip,sparx5-switch.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
index 0807aa7a8f63..57ffeb8fc876 100644
--- a/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml
@@ -130,8 +130,6 @@ required:
- reg-names
- interrupts
- interrupt-names
- - resets
- - reset-names
- ethernet-ports
additionalProperties: false
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] net: lan966x: make reset optional
2022-08-31 11:18 [PATCH net-next 0/2] net: lan966x: make reset optional Michael Walle
2022-08-31 11:18 ` [PATCH net-next 1/2] dt-bindings: net: sparx5: don't require a reset line Michael Walle
@ 2022-08-31 11:18 ` Michael Walle
2022-09-02 11:30 ` [PATCH net-next 0/2] " patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2022-08-31 11:18 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Lars Povlsen, Steen Hegelund,
Horatiu Vultur
Cc: UNGLinuxDriver, Philipp Zabel, netdev, devicetree,
linux-arm-kernel, linux-kernel, Michael Walle
There is no dedicated reset for just the switch core. The reset which
is used up until now, is more of a global reset, resetting almost the
whole SoC and cause spurious errors by doing so. Make it possible to
handle the reset elsewhere and make the reset optional.
Signed-off-by: Michael Walle <michael@walle.cc>
---
drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index 2ad078608c45..e2c77f954a3d 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -971,7 +971,8 @@ static int lan966x_reset_switch(struct lan966x *lan966x)
int val = 0;
int ret;
- switch_reset = devm_reset_control_get_shared(lan966x->dev, "switch");
+ switch_reset = devm_reset_control_get_optional_shared(lan966x->dev,
+ "switch");
if (IS_ERR(switch_reset))
return dev_err_probe(lan966x->dev, PTR_ERR(switch_reset),
"Could not obtain switch reset");
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2] net: lan966x: make reset optional
2022-08-31 11:18 [PATCH net-next 0/2] net: lan966x: make reset optional Michael Walle
2022-08-31 11:18 ` [PATCH net-next 1/2] dt-bindings: net: sparx5: don't require a reset line Michael Walle
2022-08-31 11:18 ` [PATCH net-next 2/2] net: lan966x: make reset optional Michael Walle
@ 2022-09-02 11:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-02 11:30 UTC (permalink / raw)
To: Michael Walle
Cc: davem, edumazet, kuba, pabeni, robh+dt, krzysztof.kozlowski+dt,
lars.povlsen, Steen.Hegelund, horatiu.vultur, UNGLinuxDriver,
p.zabel, netdev, devicetree, linux-arm-kernel, linux-kernel
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 31 Aug 2022 13:18:53 +0200 you wrote:
> This is the remaining part of the reset rework on the LAN966x targetting
> the netdev tree.
>
> The former series can be found at:
> https://lore.kernel.org/lkml/20220826115607.1148489-1-michael@walle.cc/
>
> Michael Walle (2):
> dt-bindings: net: sparx5: don't require a reset line
> net: lan966x: make reset optional
>
> [...]
Here is the summary with links:
- [net-next,1/2] dt-bindings: net: sparx5: don't require a reset line
https://git.kernel.org/netdev/net-next/c/baa6a9b59070
- [net-next,2/2] net: lan966x: make reset optional
https://git.kernel.org/netdev/net-next/c/f4c1f51cea4e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-02 11:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-31 11:18 [PATCH net-next 0/2] net: lan966x: make reset optional Michael Walle
2022-08-31 11:18 ` [PATCH net-next 1/2] dt-bindings: net: sparx5: don't require a reset line Michael Walle
2022-08-31 11:18 ` [PATCH net-next 2/2] net: lan966x: make reset optional Michael Walle
2022-09-02 11:30 ` [PATCH net-next 0/2] " patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).