devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/5] dt-bindings: vendor-prefixes: add Diodes
@ 2022-09-12 10:22 Martyn Welch
  2022-09-12 10:22 ` [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q Martyn Welch
  0 siblings, 1 reply; 3+ messages in thread
From: Martyn Welch @ 2022-09-12 10:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Bartosz Golaszewski, Martyn Welch, Krzysztof Kozlowski,
	Rob Herring, devicetree, linux-kernel

From: Martyn Welch <martyn.welch@collabora.com>

Diodes Incorporated is a manufacturer of application specific standard
products within the discrete, logic, analog, and mixed-signal semiconductor
markets.

https://www.diodes.com/

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

Changes in v2:
 - None

Changes in v3:
 - None

 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 2f0151e9f6be..7ee9b7692ed1 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -328,6 +328,8 @@ patternProperties:
     description: Digi International Inc.
   "^digilent,.*":
     description: Diglent, Inc.
+  "^diodes,.*":
+    description: Diodes, Inc.
   "^dioo,.*":
     description: Dioo Microcircuit Co., Ltd
   "^dlc,.*":
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q
  2022-09-12 10:22 [PATCH v3 1/5] dt-bindings: vendor-prefixes: add Diodes Martyn Welch
@ 2022-09-12 10:22 ` Martyn Welch
  2022-09-12 15:38   ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Martyn Welch @ 2022-09-12 10:22 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski
  Cc: Martyn Welch, Krzysztof Kozlowski, Krzysztof Kozlowski,
	linux-gpio, devicetree, linux-kernel

From: Martyn Welch <martyn.welch@collabora.com>

The NXP PCAL6534 is a 34-bit I2C I/O expander similar to the PCAL6524. The
Diodes PI4IOE5V6534Q is a functionally identical chip provided by Diodes
Inc.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---

Changes in v2:
 - Enumerate pi4ioe5v6534q as requiring pcal6534 fallback

Changes in v3:
 - Corrected indentation

 .../bindings/gpio/gpio-pca95xx.yaml           | 98 ++++++++++---------
 1 file changed, 52 insertions(+), 46 deletions(-)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 977b14db09b0..3f7139bca50c 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -15,52 +15,58 @@ description: |+
 
 properties:
   compatible:
-    enum:
-      - exar,xra1202
-      - maxim,max7310
-      - maxim,max7312
-      - maxim,max7313
-      - maxim,max7315
-      - maxim,max7319
-      - maxim,max7320
-      - maxim,max7321
-      - maxim,max7322
-      - maxim,max7323
-      - maxim,max7324
-      - maxim,max7325
-      - maxim,max7326
-      - maxim,max7327
-      - nxp,pca6408
-      - nxp,pca6416
-      - nxp,pca9505
-      - nxp,pca9506
-      - nxp,pca9534
-      - nxp,pca9535
-      - nxp,pca9536
-      - nxp,pca9537
-      - nxp,pca9538
-      - nxp,pca9539
-      - nxp,pca9554
-      - nxp,pca9555
-      - nxp,pca9556
-      - nxp,pca9557
-      - nxp,pca9574
-      - nxp,pca9575
-      - nxp,pca9698
-      - nxp,pcal6416
-      - nxp,pcal6524
-      - nxp,pcal9535
-      - nxp,pcal9554b
-      - nxp,pcal9555a
-      - onnn,cat9554
-      - onnn,pca9654
-      - ti,pca6107
-      - ti,pca9536
-      - ti,tca6408
-      - ti,tca6416
-      - ti,tca6424
-      - ti,tca9539
-      - ti,tca9554
+    oneOf:
+      - items:
+          - const: diodes,pi4ioe5v6534q
+          - const: nxp,pcal6534
+      - items:
+          - enum:
+            - exar,xra1202
+            - maxim,max7310
+            - maxim,max7312
+            - maxim,max7313
+            - maxim,max7315
+            - maxim,max7319
+            - maxim,max7320
+            - maxim,max7321
+            - maxim,max7322
+            - maxim,max7323
+            - maxim,max7324
+            - maxim,max7325
+            - maxim,max7326
+            - maxim,max7327
+            - nxp,pca6408
+            - nxp,pca6416
+            - nxp,pca9505
+            - nxp,pca9506
+            - nxp,pca9534
+            - nxp,pca9535
+            - nxp,pca9536
+            - nxp,pca9537
+            - nxp,pca9538
+            - nxp,pca9539
+            - nxp,pca9554
+            - nxp,pca9555
+            - nxp,pca9556
+            - nxp,pca9557
+            - nxp,pca9574
+            - nxp,pca9575
+            - nxp,pca9698
+            - nxp,pcal6416
+            - nxp,pcal6524
+            - nxp,pcal6534
+            - nxp,pcal9535
+            - nxp,pcal9554b
+            - nxp,pcal9555a
+            - onnn,cat9554
+            - onnn,pca9654
+            - ti,pca6107
+            - ti,pca9536
+            - ti,tca6408
+            - ti,tca6416
+            - ti,tca6424
+            - ti,tca9539
+            - ti,tca9554
 
   reg:
     maxItems: 1
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q
  2022-09-12 10:22 ` [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q Martyn Welch
@ 2022-09-12 15:38   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-09-12 15:38 UTC (permalink / raw)
  To: Martyn Welch
  Cc: Linus Walleij, Martyn Welch, linux-gpio, Krzysztof Kozlowski,
	Rob Herring, Krzysztof Kozlowski, Krzysztof Kozlowski,
	linux-kernel, devicetree, Bartosz Golaszewski

On Mon, 12 Sep 2022 11:22:19 +0100, Martyn Welch wrote:
> From: Martyn Welch <martyn.welch@collabora.com>
> 
> The NXP PCAL6534 is a 34-bit I2C I/O expander similar to the PCAL6524. The
> Diodes PI4IOE5V6534Q is a functionally identical chip provided by Diodes
> Inc.
> 
> Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> 
> Changes in v2:
>  - Enumerate pi4ioe5v6534q as requiring pcal6534 fallback
> 
> Changes in v3:
>  - Corrected indentation
> 
>  .../bindings/gpio/gpio-pca95xx.yaml           | 98 ++++++++++---------
>  1 file changed, 52 insertions(+), 46 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml:24:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-09-12 15:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-12 10:22 [PATCH v3 1/5] dt-bindings: vendor-prefixes: add Diodes Martyn Welch
2022-09-12 10:22 ` [PATCH v3 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q Martyn Welch
2022-09-12 15:38   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).