* [PATCH 1/4] arm64: dts: imx8mm: remove otg1/2 power domain dependency on hsio
2022-09-26 11:45 [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Li Jun
@ 2022-09-26 11:45 ` Li Jun
2022-09-26 11:45 ` [PATCH 2/4] arm64: dts: imx8mm: correct usb power domains Li Jun
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Li Jun @ 2022-09-26 11:45 UTC (permalink / raw)
To: shawnguo
Cc: l.stach, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-imx, aford173, tharvey, frieder.schrempf, marex,
devicetree, linux-arm-kernel, xu.yang_2, jun.li
pgc_otg1/2 are independent power domain of hsio, they for usb phy,
so remove hsio power domain dependency from its node.
Fixes: d39d4bb15310 ("arm64: dts: imx8mm: add GPC node")
Signed-off-by: Li Jun <jun.li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index afb90f59c83c..41204b871f4f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -674,13 +674,11 @@ pgc_pcie: power-domain@1 {
pgc_otg1: power-domain@2 {
#power-domain-cells = <0>;
reg = <IMX8MM_POWER_DOMAIN_OTG1>;
- power-domains = <&pgc_hsiomix>;
};
pgc_otg2: power-domain@3 {
#power-domain-cells = <0>;
reg = <IMX8MM_POWER_DOMAIN_OTG2>;
- power-domains = <&pgc_hsiomix>;
};
pgc_gpumix: power-domain@4 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] arm64: dts: imx8mm: correct usb power domains
2022-09-26 11:45 [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Li Jun
2022-09-26 11:45 ` [PATCH 1/4] arm64: dts: imx8mm: remove otg1/2 power domain dependency on hsio Li Jun
@ 2022-09-26 11:45 ` Li Jun
2022-09-26 11:45 ` [PATCH 3/4] arm64: dts: imx8mn: remove otg1 power domain dependency on hsio Li Jun
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Li Jun @ 2022-09-26 11:45 UTC (permalink / raw)
To: shawnguo
Cc: l.stach, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-imx, aford173, tharvey, frieder.schrempf, marex,
devicetree, linux-arm-kernel, xu.yang_2, jun.li
pgc_otg1/2 is actual the power domain of usb PHY, usb controller
is in hsio power domain, and pgc_otg1/2 is required to be powered
up to detect usb remote wakeup, so move the pgc_otg1/2 power domain
to the usb phy node.
Fixes: 01df28d80859 ("arm64: dts: imx8mm: put USB controllers into power-domains")
Signed-off-by: Li Jun <jun.li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 41204b871f4f..dabd94dc30c4 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -276,6 +276,7 @@ usbphynop1: usbphynop1 {
assigned-clocks = <&clk IMX8MM_CLK_USB_PHY_REF>;
assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_100M>;
clock-names = "main_clk";
+ power-domains = <&pgc_otg1>;
};
usbphynop2: usbphynop2 {
@@ -285,6 +286,7 @@ usbphynop2: usbphynop2 {
assigned-clocks = <&clk IMX8MM_CLK_USB_PHY_REF>;
assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_100M>;
clock-names = "main_clk";
+ power-domains = <&pgc_otg2>;
};
soc: soc@0 {
@@ -1184,7 +1186,7 @@ usbotg1: usb@32e40000 {
assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_500M>;
phys = <&usbphynop1>;
fsl,usbmisc = <&usbmisc1 0>;
- power-domains = <&pgc_otg1>;
+ power-domains = <&pgc_hsiomix>;
status = "disabled";
};
@@ -1204,7 +1206,7 @@ usbotg2: usb@32e50000 {
assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_500M>;
phys = <&usbphynop2>;
fsl,usbmisc = <&usbmisc2 0>;
- power-domains = <&pgc_otg2>;
+ power-domains = <&pgc_hsiomix>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] arm64: dts: imx8mn: remove otg1 power domain dependency on hsio
2022-09-26 11:45 [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Li Jun
2022-09-26 11:45 ` [PATCH 1/4] arm64: dts: imx8mm: remove otg1/2 power domain dependency on hsio Li Jun
2022-09-26 11:45 ` [PATCH 2/4] arm64: dts: imx8mm: correct usb power domains Li Jun
@ 2022-09-26 11:45 ` Li Jun
2022-09-26 11:45 ` [PATCH 4/4] arm64: dts: imx8mn: Correct the usb power domain Li Jun
2022-10-24 1:37 ` [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Shawn Guo
4 siblings, 0 replies; 6+ messages in thread
From: Li Jun @ 2022-09-26 11:45 UTC (permalink / raw)
To: shawnguo
Cc: l.stach, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-imx, aford173, tharvey, frieder.schrempf, marex,
devicetree, linux-arm-kernel, xu.yang_2, jun.li
pgc_otg1 is an independent power domain of hsio, it's for usb phy,
so remove hsio power domain from its node.
Fixes: 8b8ebec67360 ("arm64: dts: imx8mn: add GPC node")
Signed-off-by: Li Jun <jun.li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 0c71b740a316..81a1179d042e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -662,7 +662,6 @@ pgc_hsiomix: power-domain@0 {
pgc_otg1: power-domain@1 {
#power-domain-cells = <0>;
reg = <IMX8MN_POWER_DOMAIN_OTG1>;
- power-domains = <&pgc_hsiomix>;
};
pgc_gpumix: power-domain@2 {
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] arm64: dts: imx8mn: Correct the usb power domain
2022-09-26 11:45 [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Li Jun
` (2 preceding siblings ...)
2022-09-26 11:45 ` [PATCH 3/4] arm64: dts: imx8mn: remove otg1 power domain dependency on hsio Li Jun
@ 2022-09-26 11:45 ` Li Jun
2022-10-24 1:37 ` [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Shawn Guo
4 siblings, 0 replies; 6+ messages in thread
From: Li Jun @ 2022-09-26 11:45 UTC (permalink / raw)
To: shawnguo
Cc: l.stach, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-imx, aford173, tharvey, frieder.schrempf, marex,
devicetree, linux-arm-kernel, xu.yang_2, jun.li
pgc_otg1 is actual the power domain of usb PHY, usb controller
is in hsio power domain, and pgc_otg1 is required to be powered
up to detect usb remote wakeup, so move the pgc_otg1 power domain
to the usb phy node.
Fixes: ea2b5af58ab2 ("arm64: dts: imx8mn: put USB controller into power-domains")
Signed-off-by: Li Jun <jun.li@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index 81a1179d042e..b6ce2bdc69b2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -1076,7 +1076,7 @@ usbotg1: usb@32e40000 {
assigned-clock-parents = <&clk IMX8MN_SYS_PLL2_500M>;
phys = <&usbphynop1>;
fsl,usbmisc = <&usbmisc1 0>;
- power-domains = <&pgc_otg1>;
+ power-domains = <&pgc_hsiomix>;
status = "disabled";
};
@@ -1175,5 +1175,6 @@ usbphynop1: usbphynop1 {
assigned-clocks = <&clk IMX8MN_CLK_USB_PHY_REF>;
assigned-clock-parents = <&clk IMX8MN_SYS_PLL1_100M>;
clock-names = "main_clk";
+ power-domains = <&pgc_otg1>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n
2022-09-26 11:45 [PATCH 0/4] Split usb otg1/2 power domain from hsio for imx8mm/n Li Jun
` (3 preceding siblings ...)
2022-09-26 11:45 ` [PATCH 4/4] arm64: dts: imx8mn: Correct the usb power domain Li Jun
@ 2022-10-24 1:37 ` Shawn Guo
4 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-10-24 1:37 UTC (permalink / raw)
To: Li Jun
Cc: l.stach, robh+dt, krzysztof.kozlowski+dt, s.hauer, kernel,
festevam, linux-imx, aford173, tharvey, frieder.schrempf, marex,
devicetree, linux-arm-kernel, xu.yang_2
On Mon, Sep 26, 2022 at 07:45:31PM +0800, Li Jun wrote:
> Actually otg1/2 power domain is for usb phy, which is required
> to be powered up for usb remote up(e.g usb runtime suspended),
> this patch set is to split the otg1/2 power domain from hsio,
> so hsio power domain can be off but otg1/2 is on for runtime
> PM.
>
> Li Jun (4):
> arm64: dts: imx8mm: remove otg1/2 power domain dependency on hsio
> arm64: dts: imx8mm: correct usb power domains
> arm64: dts: imx8mn: remove otg1 power domain dependency on hsio
> arm64: dts: imx8mn: Correct the usb power domain
Applied all, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread