From: Rob Herring <robh@kernel.org>
To: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
ihkose@gmail.com, devicetree@vger.kernel.org,
rajat.khandelwal@intel.com, lars@metafoo.de, jic23@kernel.org,
linux-iio@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH] Change the I2C slave address for ds4422/4424 to its correct value
Date: Mon, 10 Oct 2022 20:52:12 -0500 [thread overview]
Message-ID: <166545307700.1702218.811193663081885499.robh@kernel.org> (raw)
In-Reply-To: <20221011182437.662719-1-rajat.khandelwal@linux.intel.com>
On Tue, 11 Oct 2022 23:54:37 +0530, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.
>
> Let me know if I am wrong about this.
>
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> ---
> Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/dac/maxim,ds4424.example.dts:22.20-26.15: Warning (i2c_bus_reg): /example-0/i2c/dac@10: I2C bus unit address format error, expected "20"
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2022-10-11 1:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 18:24 [PATCH] Change the I2C slave address for ds4422/4424 to its correct value Rajat Khandelwal
2022-10-10 18:38 ` Krzysztof Kozlowski
2022-10-11 7:47 ` Khandelwal, Rajat
2022-10-11 1:52 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166545307700.1702218.811193663081885499.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ihkose@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajat.khandelwal@intel.com \
--cc=rajat.khandelwal@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox