From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
dianders@chromium.org, quic_vpolimer@quicinc.com,
swboyd@chromium.org, quic_kalyant@quicinc.com,
dmitry.baryshkov@linaro.org, quic_khsieh@quicinc.com,
quic_vproddut@quicinc.com, quic_bjorande@quicinc.com,
quic_aravindh@quicinc.com, quic_abhinavk@quicinc.com
Subject: [PATCH v8 06/15] drm/msm/dp: disable self_refresh_aware after entering psr
Date: Wed, 12 Oct 2022 17:32:30 +0530 [thread overview]
Message-ID: <1665576159-3749-7-git-send-email-quic_vpolimer@quicinc.com> (raw)
In-Reply-To: <1665576159-3749-1-git-send-email-quic_vpolimer@quicinc.com>
From: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Updated frames get queued if self_refresh_aware is set when the
sink is in psr. To support bridge enable and avoid queuing of update
frames, reset the self_refresh_aware state after entering psr.
Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
---
drivers/gpu/drm/msm/dp/dp_drm.c | 27 ++++++++++++++++++++++++++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index 3e8912b..818c105 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -100,6 +100,8 @@ static void edp_bridge_atomic_enable(struct drm_bridge *drm_bridge,
struct drm_crtc_state *old_crtc_state;
struct msm_dp_bridge *dp_bridge = to_dp_bridge(drm_bridge);
struct msm_dp *dp = dp_bridge->dp_display;
+ struct drm_connector *connector;
+ struct drm_connector_state *conn_state = NULL;
/*
* Check the old state of the crtc to determine if the panel
@@ -116,10 +118,22 @@ static void edp_bridge_atomic_enable(struct drm_bridge *drm_bridge,
if (old_crtc_state && old_crtc_state->self_refresh_active) {
dp_display_set_psr(dp, false);
- return;
+ goto psr_aware;
}
dp_bridge_atomic_enable(drm_bridge, old_bridge_state);
+
+psr_aware:
+ connector = drm_atomic_get_new_connector_for_encoder(atomic_state,
+ drm_bridge->encoder);
+ if (connector)
+ conn_state = drm_atomic_get_new_connector_state(atomic_state,
+ connector);
+
+ if (conn_state) {
+ conn_state->self_refresh_aware = dp->psr_supported;
+ }
+
}
static void edp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
@@ -130,6 +144,14 @@ static void edp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
struct drm_crtc_state *new_crtc_state = NULL, *old_crtc_state = NULL;
struct msm_dp_bridge *dp_bridge = to_dp_bridge(drm_bridge);
struct msm_dp *dp = dp_bridge->dp_display;
+ struct drm_connector *connector;
+ struct drm_connector_state *conn_state = NULL;
+
+ connector = drm_atomic_get_old_connector_for_encoder(atomic_state,
+ drm_bridge->encoder);
+ if (connector)
+ conn_state = drm_atomic_get_new_connector_state(atomic_state,
+ connector);
crtc = drm_atomic_get_old_crtc_for_encoder(atomic_state,
drm_bridge->encoder);
@@ -156,6 +178,9 @@ static void edp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
* when display disable occurs while the sink is in psr state.
*/
if (new_crtc_state->self_refresh_active) {
+ if (conn_state)
+ conn_state->self_refresh_aware = false;
+
dp_display_set_psr(dp, true);
return;
} else if (old_crtc_state->self_refresh_active) {
--
2.7.4
next prev parent reply other threads:[~2022-10-12 12:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 12:02 [PATCH v8 00/15] Add PSR support for eDP Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc Vinod Polimera
2022-10-24 15:22 ` Dmitry Baryshkov
2022-10-27 13:34 ` Vinod Polimera
2022-10-27 17:40 ` Dmitry Baryshkov
2022-11-01 11:16 ` Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 02/15] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 03/15] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 04/15] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 05/15] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2022-10-12 12:02 ` Vinod Polimera [this message]
2022-10-12 12:02 ` [PATCH v8 07/15] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 08/15] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 09/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 10/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 11/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 12/15] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera
2022-11-01 12:15 ` Marijn Suijten
2022-10-12 12:02 ` [PATCH v8 13/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 14/15] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera
2022-10-12 12:02 ` [PATCH v8 15/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup Vinod Polimera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1665576159-3749-7-git-send-email-quic_vpolimer@quicinc.com \
--to=quic_vpolimer@quicinc.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).