From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2135C43217 for ; Thu, 20 Oct 2022 12:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiJTM4Z (ORCPT ); Thu, 20 Oct 2022 08:56:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiJTM4Y (ORCPT ); Thu, 20 Oct 2022 08:56:24 -0400 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B0C143A58; Thu, 20 Oct 2022 05:56:23 -0700 (PDT) Received: by mail-oi1-f180.google.com with SMTP id y72so22748065oia.3; Thu, 20 Oct 2022 05:56:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=date:subject:message-id:references:in-reply-to:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G+oTd/mCAc9rHiVxX6LMM1ilKK5nolYQ0/R9nLcKiZg=; b=wSJANCiukQiAzjTLr2ckqf8oWbN/WeN9L3GORQLe8stkbW7ph15ExZMjaQejQdObIf IIBbdN/SwNWs6phJhkBC1BwkmpMVIqG+PS69h6DxCu/r4jU8hQIFnGwGWg7+TpzJjARt zNm36GHseKBai0RVr8UpLr1BH8S6xWU3pLbaaPyHVO5FQvCx64t9rn6blQYZgQD0TPIx kg8jcGVpoQHkgxuNtbCdeY064VyHp71iv853uptYXNGChkawV7odBj52wnPsTlffhvGp +k2m77b26CNBVo+R6RolHdXPKEKZ8rhVzrVAPIrv/7vzEA6ogGhxpZii/2KH1bNhQKlZ eRtA== X-Gm-Message-State: ACrzQf2pN5ckrnWDGWzIOCiZTAF5YjJDNnpIbLJ1SC/vzRlME5wAUZxl 2HzMd746ms4A4i49YhR1GH7TBBG/Qg== X-Google-Smtp-Source: AMsMyM53EIlej7wyTgu+ZyVv6pofUu9es2O1fZp/sq0pnlM7atRmQSy/1MXky98/LAspLDGWIsmXLA== X-Received: by 2002:a05:6808:141:b0:354:9436:2e53 with SMTP id h1-20020a056808014100b0035494362e53mr7168830oie.219.1666270582152; Thu, 20 Oct 2022 05:56:22 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id x9-20020a9d5889000000b00661b9421daesm7936626otg.69.2022.10.20.05.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 05:56:21 -0700 (PDT) Received: (nullmailer pid 1111918 invoked by uid 1000); Thu, 20 Oct 2022 12:56:23 -0000 From: Rob Herring To: Cosmin Tanislav Cc: =?utf-8?q?Nuno_S=C3=A1?= , Rob Herring , Lars-Peter Clausen , Michael Hennerich , linux-iio@vger.kernel.org, Krzysztof Kozlowski , Jonathan Cameron , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Cosmin Tanislav In-Reply-To: <20221020090257.1717053-4-demonsingur@gmail.com> References: <20221020090257.1717053-1-demonsingur@gmail.com> <20221020090257.1717053-4-demonsingur@gmail.com> Message-Id: <166626973810.1095953.8246323688783292812.robh@kernel.org> Subject: Re: [PATCH v2 3/5] dt-bindings: iio: temperature: ltc2983: refine Date: Thu, 20 Oct 2022 07:56:23 -0500 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 20 Oct 2022 12:02:55 +0300, Cosmin Tanislav wrote: > From: Cosmin Tanislav > > * make sure addresses are represented as hex > * add note about wrong unit value for adi,mux-delay-config-us > * simplify descriptions > * add descriptions for the items of custom sensor tables > * add default property values where applicable > * use conditionals to extend minimum reg value > for single ended sensors > * remove " around phandle schema $ref > * remove label from example and use generic temperature > sensor name > > Signed-off-by: Cosmin Tanislav > --- > .../bindings/iio/temperature/adi,ltc2983.yaml | 309 +++++++++++------- > 1 file changed, 182 insertions(+), 127 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^diode@:allOf:0:if:properties:adi,single-ended:const: True is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermocouple@:allOf:0:if:properties:adi,single-ended:const: True is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^adc@:allOf:0:if:properties:adi,single-ended:const: True is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: patternProperties:^thermistor@:allOf:0:if:properties:adi,single-ended:const: True is not of type 'integer', 'string' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.