From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
Thara Gopinath <thara.gopinath@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine
Date: Tue, 19 May 2026 09:27:58 +0200 [thread overview]
Message-ID: <166e09b6-2fd7-450a-b7df-b59b961bdfe2@kernel.org> (raw)
In-Reply-To: <f40798ef-e066-4814-a26c-729dcdb9f5b1@oss.qualcomm.com>
On 19/05/2026 09:09, Kuldeep Singh wrote:
> On 15-05-2026 16:30, Krzysztof Kozlowski wrote:
>> On 14/05/2026 21:23, Kuldeep Singh wrote:
>>> Document the crypto engine on the Shikra platform.
>>>
>>> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
>>> ---
>>
>> Same comments as for IPQ, Nord. I gave the same feedback internally more
>> than once.
>
> If i understand you correctly, you are looking for more descriptive
> commit message?
>
No, about proper patch organizing into one paychset instead of sending 5
different patchsets with oneliners. That's literally the last
thread/feedback on internal Open source forum chat, so easy to find.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-19 7:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
2026-05-14 19:23 ` [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
2026-05-15 11:00 ` Krzysztof Kozlowski
2026-05-19 7:09 ` Kuldeep Singh
2026-05-19 7:27 ` Krzysztof Kozlowski [this message]
2026-05-19 8:55 ` Kuldeep Singh
2026-05-14 19:23 ` [PATCH 2/3] dt-bindings: bam-dma: Increase maxItems to seven for iommus Kuldeep Singh
2026-05-14 19:23 ` [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support Kuldeep Singh
2026-05-15 10:28 ` Konrad Dybcio
2026-05-14 19:47 ` [PATCH 0/3] Add support for qcrypto on shikra Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166e09b6-2fd7-450a-b7df-b59b961bdfe2@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thara.gopinath@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox