From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: <dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>
Cc: Vinod Polimera <quic_vpolimer@quicinc.com>,
<linux-kernel@vger.kernel.org>, <robdclark@gmail.com>,
<dianders@chromium.org>, <swboyd@chromium.org>,
<quic_kalyant@quicinc.com>, <dmitry.baryshkov@linaro.org>,
<quic_khsieh@quicinc.com>, <quic_vproddut@quicinc.com>,
<quic_bjorande@quicinc.com>, <quic_abhinavk@quicinc.com>,
<quic_sbillaka@quicinc.com>
Subject: [PATCH Resend v11 09/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources
Date: Thu, 19 Jan 2023 19:56:27 +0530 [thread overview]
Message-ID: <1674138393-475-10-git-send-email-quic_vpolimer@quicinc.com> (raw)
In-Reply-To: <1674138393-475-1-git-send-email-quic_vpolimer@quicinc.com>
According to KMS documentation, The driver must not release any shared
resources if active is set to false but enable still true.
Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset")
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 1757856..29d6cda 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -651,7 +651,7 @@ static int dpu_encoder_virt_atomic_check(
if (drm_atomic_crtc_needs_modeset(crtc_state)) {
dpu_rm_release(global_state, drm_enc);
- if (!crtc_state->active_changed || crtc_state->active)
+ if (!crtc_state->active_changed || crtc_state->enable)
ret = dpu_rm_reserve(&dpu_kms->rm, global_state,
drm_enc, crtc_state, topology);
}
--
2.7.4
next prev parent reply other threads:[~2023-01-19 14:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 14:26 [PATCH Resend v11 00/15] Add PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 01/15] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 02/15] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 03/15] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 04/15] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr Vinod Polimera
2023-01-24 0:21 ` Dmitry Baryshkov
2023-01-24 15:09 ` Vinod Polimera
2023-01-24 16:45 ` Dmitry Baryshkov
2023-01-27 15:00 ` Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 06/15] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 07/15] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 08/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2023-01-19 14:26 ` Vinod Polimera [this message]
2023-01-19 14:26 ` [PATCH Resend v11 10/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 11/15] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera
2023-01-24 0:24 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 12/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera
2023-01-24 0:25 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 13/15] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera
2023-01-24 0:26 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 14/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup Vinod Polimera
2023-01-24 0:28 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 15/15] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh Vinod Polimera
2023-01-24 0:30 ` Dmitry Baryshkov
2023-01-24 0:32 ` [PATCH Resend v11 00/15] Add PSR support for eDP Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1674138393-475-10-git-send-email-quic_vpolimer@quicinc.com \
--to=quic_vpolimer@quicinc.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).