From: Vinod Polimera <quic_vpolimer@quicinc.com>
To: <dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>, <devicetree@vger.kernel.org>
Cc: Vinod Polimera <quic_vpolimer@quicinc.com>,
<linux-kernel@vger.kernel.org>, <robdclark@gmail.com>,
<dianders@chromium.org>, <swboyd@chromium.org>,
<quic_kalyant@quicinc.com>, <dmitry.baryshkov@linaro.org>,
<quic_khsieh@quicinc.com>, <quic_vproddut@quicinc.com>,
<quic_bjorande@quicinc.com>, <quic_abhinavk@quicinc.com>,
<quic_sbillaka@quicinc.com>
Subject: [PATCH Resend v11 02/15] drm/msm/dp: use atomic callbacks for DP bridge ops
Date: Thu, 19 Jan 2023 19:56:20 +0530 [thread overview]
Message-ID: <1674138393-475-3-git-send-email-quic_vpolimer@quicinc.com> (raw)
In-Reply-To: <1674138393-475-1-git-send-email-quic_vpolimer@quicinc.com>
Use atomic variants for DP bridge callback functions so that
the atomic state can be accessed in the interface drivers.
The atomic state will help the driver find out if the display
is in self refresh state.
Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>
Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
drivers/gpu/drm/msm/dp/dp_display.c | 9 ++++++---
drivers/gpu/drm/msm/dp/dp_drm.c | 6 +++---
drivers/gpu/drm/msm/dp/dp_drm.h | 9 ++++++---
3 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index bde1a7c..985287e 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1652,7 +1652,8 @@ int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
return 0;
}
-void dp_bridge_enable(struct drm_bridge *drm_bridge)
+void dp_bridge_atomic_enable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state)
{
struct msm_dp_bridge *dp_bridge = to_dp_bridge(drm_bridge);
struct msm_dp *dp = dp_bridge->dp_display;
@@ -1707,7 +1708,8 @@ void dp_bridge_enable(struct drm_bridge *drm_bridge)
mutex_unlock(&dp_display->event_mutex);
}
-void dp_bridge_disable(struct drm_bridge *drm_bridge)
+void dp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state)
{
struct msm_dp_bridge *dp_bridge = to_dp_bridge(drm_bridge);
struct msm_dp *dp = dp_bridge->dp_display;
@@ -1718,7 +1720,8 @@ void dp_bridge_disable(struct drm_bridge *drm_bridge)
dp_ctrl_push_idle(dp_display->ctrl);
}
-void dp_bridge_post_disable(struct drm_bridge *drm_bridge)
+void dp_bridge_atomic_post_disable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state)
{
struct msm_dp_bridge *dp_bridge = to_dp_bridge(drm_bridge);
struct msm_dp *dp = dp_bridge->dp_display;
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c
index 275370f..3252d50 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.c
+++ b/drivers/gpu/drm/msm/dp/dp_drm.c
@@ -94,9 +94,9 @@ static const struct drm_bridge_funcs dp_bridge_ops = {
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
.atomic_reset = drm_atomic_helper_bridge_reset,
- .enable = dp_bridge_enable,
- .disable = dp_bridge_disable,
- .post_disable = dp_bridge_post_disable,
+ .atomic_enable = dp_bridge_atomic_enable,
+ .atomic_disable = dp_bridge_atomic_disable,
+ .atomic_post_disable = dp_bridge_atomic_post_disable,
.mode_set = dp_bridge_mode_set,
.mode_valid = dp_bridge_mode_valid,
.get_modes = dp_bridge_get_modes,
diff --git a/drivers/gpu/drm/msm/dp/dp_drm.h b/drivers/gpu/drm/msm/dp/dp_drm.h
index 250f7c6..afe79b8 100644
--- a/drivers/gpu/drm/msm/dp/dp_drm.h
+++ b/drivers/gpu/drm/msm/dp/dp_drm.h
@@ -23,9 +23,12 @@ struct drm_connector *dp_drm_connector_init(struct msm_dp *dp_display, struct dr
struct drm_bridge *dp_bridge_init(struct msm_dp *dp_display, struct drm_device *dev,
struct drm_encoder *encoder);
-void dp_bridge_enable(struct drm_bridge *drm_bridge);
-void dp_bridge_disable(struct drm_bridge *drm_bridge);
-void dp_bridge_post_disable(struct drm_bridge *drm_bridge);
+void dp_bridge_atomic_enable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state);
+void dp_bridge_atomic_disable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state);
+void dp_bridge_atomic_post_disable(struct drm_bridge *drm_bridge,
+ struct drm_bridge_state *old_bridge_state);
enum drm_mode_status dp_bridge_mode_valid(struct drm_bridge *bridge,
const struct drm_display_info *info,
const struct drm_display_mode *mode);
--
2.7.4
next prev parent reply other threads:[~2023-01-19 14:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 14:26 [PATCH Resend v11 00/15] Add PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 01/15] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2023-01-19 14:26 ` Vinod Polimera [this message]
2023-01-19 14:26 ` [PATCH Resend v11 03/15] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 04/15] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr Vinod Polimera
2023-01-24 0:21 ` Dmitry Baryshkov
2023-01-24 15:09 ` Vinod Polimera
2023-01-24 16:45 ` Dmitry Baryshkov
2023-01-27 15:00 ` Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 06/15] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 07/15] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 08/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 09/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 10/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 11/15] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera
2023-01-24 0:24 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 12/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera
2023-01-24 0:25 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 13/15] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera
2023-01-24 0:26 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 14/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup Vinod Polimera
2023-01-24 0:28 ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 15/15] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh Vinod Polimera
2023-01-24 0:30 ` Dmitry Baryshkov
2023-01-24 0:32 ` [PATCH Resend v11 00/15] Add PSR support for eDP Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1674138393-475-3-git-send-email-quic_vpolimer@quicinc.com \
--to=quic_vpolimer@quicinc.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).