From: "Heiko Stübner" <heiko@sntech.de>
To: Conor Dooley <conor@kernel.org>
Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com,
sam@ravnborg.org, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
quentin.schulz@theobroma-systems.com,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH 2/3] dt-bindings: display: ltk500hd1829: add variant compatible for ltk101b4029w
Date: Thu, 15 Feb 2024 22:17:43 +0100 [thread overview]
Message-ID: <16747948.geO5KgaWL5@diego> (raw)
In-Reply-To: <20240215-boat-grid-d50f0eccec67@spud>
Am Donnerstag, 15. Februar 2024, 18:06:06 CET schrieb Conor Dooley:
> On Thu, Feb 15, 2024 at 10:05:14AM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@cherry.de>
> >
> > Add the compatible for the ltk101b4029w panel, that is really similar
> > to the ltk500hd1829.
>
> Please mention what makes the devices incompatible. "really similar" is
> vague and could be used for a device that was only cosmetically
> different.
ok, I'll modify the paragraph to:
=======
Add the compatible for the ltk101b4029w panel, that has the same
manufacturer, general bringup and supplies but a different dsi-init-
sequence as the ltk500hd1829 .
=======
> With that,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> > ---
> > .../bindings/display/panel/leadtek,ltk500hd1829.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > index c5944b4d636c5..d589f16772145 100644
> > --- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
> > @@ -14,7 +14,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: leadtek,ltk500hd1829
> > + enum:
> > + - leadtek,ltk101b4029w
> > + - leadtek,ltk500hd1829
> > reg: true
> > backlight: true
> > reset-gpios: true
>
next prev parent reply other threads:[~2024-02-15 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 9:05 [PATCH 0/3] drm/panel: add one more Leadtek panel, the ltk101b4029w Heiko Stuebner
2024-02-15 9:05 ` [PATCH 1/3] drm/panel: ltk500hd1829: make room for more similar panels Heiko Stuebner
2024-02-15 16:25 ` Jessica Zhang
2024-02-15 9:05 ` [PATCH 2/3] dt-bindings: display: ltk500hd1829: add variant compatible for ltk101b4029w Heiko Stuebner
2024-02-15 17:06 ` Conor Dooley
2024-02-15 21:17 ` Heiko Stübner [this message]
2024-02-15 9:05 ` [PATCH 3/3] drm/panel: ltk500hd1829: add panel type " Heiko Stuebner
2024-02-15 16:30 ` Jessica Zhang
2024-02-15 9:40 ` [PATCH 0/3] drm/panel: add one more Leadtek panel, the ltk101b4029w Quentin Schulz
2024-02-16 22:51 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16747948.geO5KgaWL5@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@cherry.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).