devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450
@ 2023-02-21 13:36 Mukesh Ojha
  2023-02-21 13:36 ` [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
  2023-02-21 15:35 ` [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Rob Herring
  0 siblings, 2 replies; 4+ messages in thread
From: Mukesh Ojha @ 2023-02-21 13:36 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	elder
  Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha

Add compatible for sm8450 IMEM.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
  - Added Acked-by .

 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 665c06e..ba694ce 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,sdm845-imem
           - qcom,sdx55-imem
           - qcom,sdx65-imem
+          - qcom,sm8450-imem
       - const: syscon
       - const: simple-mfd
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
  2023-02-21 13:36 [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
@ 2023-02-21 13:36 ` Mukesh Ojha
  2023-02-21 17:47   ` Konrad Dybcio
  2023-02-21 15:35 ` [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Rob Herring
  1 sibling, 1 reply; 4+ messages in thread
From: Mukesh Ojha @ 2023-02-21 13:36 UTC (permalink / raw)
  To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
	elder
  Cc: linux-arm-msm, devicetree, linux-kernel, Mukesh Ojha

Add a simple-mfd representing IMEM on SM8450 and define the PIL
relocation info region, so that post mortem tools will be able
to locate the loaded remoteprocs.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Changes in v2:
 -  put ranges after regs and corrected the sram node position.

 arch/arm64/boot/dts/qcom/sm8450.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 1a744a3..2a4f4ac 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -3814,6 +3814,20 @@
 			};
 		};
 
+		sram@146aa000 {
+			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
+			reg = <0 0x146aa000 0 0x1000>;
+			ranges = <0 0 0x146aa000 0x1000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			pil-reloc@94c {
+				compatible = "qcom,pil-reloc-info";
+				reg = <0x94c 0xc8>;
+			};
+		};
+
 		timer@17420000 {
 			compatible = "arm,armv7-timer-mem";
 			#address-cells = <1>;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450
  2023-02-21 13:36 [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
  2023-02-21 13:36 ` [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
@ 2023-02-21 15:35 ` Rob Herring
  1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-02-21 15:35 UTC (permalink / raw)
  To: Mukesh Ojha
  Cc: krzysztof.kozlowski+dt, devicetree, agross, elder, konrad.dybcio,
	andersson, linux-kernel, linux-arm-msm, robh+dt


On Tue, 21 Feb 2023 19:06:55 +0530, Mukesh Ojha wrote:
> Add compatible for sm8450 IMEM.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes in v2:
>   - Added Acked-by .
> 
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region
  2023-02-21 13:36 ` [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
@ 2023-02-21 17:47   ` Konrad Dybcio
  0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-02-21 17:47 UTC (permalink / raw)
  To: Mukesh Ojha, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
	elder
  Cc: linux-arm-msm, devicetree, linux-kernel



On 21.02.2023 14:36, Mukesh Ojha wrote:
> Add a simple-mfd representing IMEM on SM8450 and define the PIL
> relocation info region, so that post mortem tools will be able
> to locate the loaded remoteprocs.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Changes in v2:
>  -  put ranges after regs and corrected the sram node position.
> 
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 1a744a3..2a4f4ac 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -3814,6 +3814,20 @@
>  			};
>  		};
>  
> +		sram@146aa000 {
Looks like it's not sorted properly? Should be between
TLMM and apss_smmu address-wise.

Konrad
> +			compatible = "qcom,sm8450-imem", "syscon", "simple-mfd";
> +			reg = <0 0x146aa000 0 0x1000>;
> +			ranges = <0 0 0x146aa000 0x1000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			pil-reloc@94c {
> +				compatible = "qcom,pil-reloc-info";
> +				reg = <0x94c 0xc8>;
> +			};
> +		};
> +
>  		timer@17420000 {
>  			compatible = "arm,armv7-timer-mem";
>  			#address-cells = <1>;

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-21 17:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-21 13:36 [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Mukesh Ojha
2023-02-21 13:36 ` [PATCH v2 2/2] arm64: dts: qcom: sm8450: Add IMEM and PIL info region Mukesh Ojha
2023-02-21 17:47   ` Konrad Dybcio
2023-02-21 15:35 ` [PATCH v2 1/2] dt-bindings: sram: qcom,imem: document sm8450 Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).