From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, marius.cristea@microchip.com,
jic23@kernel.org, lars@metafoo.de, robh@kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, krzk+dt@kernel.org,
conor+dt@kernel.org, oskar.andero@gmail.com,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, marius.cristea@microchip.com
Subject: Re: [PATCH v2 2/2] iio: adc: adding support for PAC194X
Date: Mon, 24 Mar 2025 08:57:02 +0300 [thread overview]
Message-ID: <167bb94a-4c9d-4499-aa7a-cc38428d7297@stanley.mountain> (raw)
In-Reply-To: <20250317090803.30003-3-marius.cristea@microchip.com>
Hi,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/marius-cristea-microchip-com/dt-bindings-iio-adc-adding-support-for-PAC194X/20250317-171150
base: 577a66e2e634f712384c57a98f504c44ea4b47da
patch link: https://lore.kernel.org/r/20250317090803.30003-3-marius.cristea%40microchip.com
patch subject: [PATCH v2 2/2] iio: adc: adding support for PAC194X
config: arm64-randconfig-r071-20250322 (https://download.01.org/0day-ci/archive/20250323/202503230315.DVkVt7Ag-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project c2692afc0a92cd5da140dfcdfff7818a5b8ce997)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202503230315.DVkVt7Ag-lkp@intel.com/
smatch warnings:
drivers/iio/adc/pac1944.c:1707 pac1944_retrieve_data() error: uninitialized symbol 'ret'.
drivers/iio/adc/pac1944.c:2463 pac1944_write_thresh() warn: inconsistent indenting
vim +/ret +1707 drivers/iio/adc/pac1944.c
e227d6e5b38646 Marius Cristea 2025-03-17 1681 static int pac1944_retrieve_data(struct pac1944_chip_info *info, u32 wait_time)
e227d6e5b38646 Marius Cristea 2025-03-17 1682 {
e227d6e5b38646 Marius Cristea 2025-03-17 1683 int ret;
e227d6e5b38646 Marius Cristea 2025-03-17 1684
e227d6e5b38646 Marius Cristea 2025-03-17 1685 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1686 * Check if the minimal elapsed time has passed and if so,
e227d6e5b38646 Marius Cristea 2025-03-17 1687 * re-read the chip, otherwise the cached info is just fine
e227d6e5b38646 Marius Cristea 2025-03-17 1688 */
e227d6e5b38646 Marius Cristea 2025-03-17 1689 if (time_after(jiffies, info->chip_reg_data.jiffies_tstamp +
e227d6e5b38646 Marius Cristea 2025-03-17 1690 msecs_to_jiffies(PAC1944_MIN_POLLING_TIME_MS))) {
e227d6e5b38646 Marius Cristea 2025-03-17 1691 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1692 * We need to re-read the chip values
e227d6e5b38646 Marius Cristea 2025-03-17 1693 * call the pac1944_reg_snapshot
e227d6e5b38646 Marius Cristea 2025-03-17 1694 */
e227d6e5b38646 Marius Cristea 2025-03-17 1695 ret = pac1944_reg_snapshot(info, true,
e227d6e5b38646 Marius Cristea 2025-03-17 1696 PAC1944_REFRESH_REG_ADDR,
e227d6e5b38646 Marius Cristea 2025-03-17 1697 wait_time);
e227d6e5b38646 Marius Cristea 2025-03-17 1698 /*
e227d6e5b38646 Marius Cristea 2025-03-17 1699 * Re-schedule the work for the read registers timeout
e227d6e5b38646 Marius Cristea 2025-03-17 1700 * (to prevent chip regs saturation)
e227d6e5b38646 Marius Cristea 2025-03-17 1701 */
e227d6e5b38646 Marius Cristea 2025-03-17 1702 cancel_delayed_work_sync(&info->work_chip_rfsh);
e227d6e5b38646 Marius Cristea 2025-03-17 1703 schedule_delayed_work(&info->work_chip_rfsh,
e227d6e5b38646 Marius Cristea 2025-03-17 1704 msecs_to_jiffies(PAC1944_MAX_RFSH_LIMIT_MS));
e227d6e5b38646 Marius Cristea 2025-03-17 1705 }
ret isn't initialized on else path.
e227d6e5b38646 Marius Cristea 2025-03-17 1706
e227d6e5b38646 Marius Cristea 2025-03-17 @1707 return ret;
e227d6e5b38646 Marius Cristea 2025-03-17 1708 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-03-24 5:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 9:08 [PATCH v2 0/2] adding support for Microchip PAC194X Power Monitor marius.cristea
2025-03-17 9:08 ` [PATCH v2 1/2] dt-bindings: iio: adc: adding support for PAC194X marius.cristea
2025-03-17 10:20 ` Rob Herring (Arm)
2025-03-17 12:32 ` Jonathan Cameron
2025-03-17 9:08 ` [PATCH v2 2/2] " marius.cristea
2025-03-17 18:47 ` Jonathan Cameron
2025-03-18 7:05 ` kernel test robot
2025-03-18 7:53 ` kernel test robot
2025-03-19 7:30 ` kernel test robot
2025-03-24 5:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167bb94a-4c9d-4499-aa7a-cc38428d7297@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marius.cristea@microchip.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=oskar.andero@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox