From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7C1C433F5 for ; Tue, 29 Mar 2022 20:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232517AbiC2U41 convert rfc822-to-8bit (ORCPT ); Tue, 29 Mar 2022 16:56:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232034AbiC2U40 (ORCPT ); Tue, 29 Mar 2022 16:56:26 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19F114B41F for ; Tue, 29 Mar 2022 13:54:41 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZIrO-0006gC-7o; Tue, 29 Mar 2022 22:54:38 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Krzysztof Kozlowski Cc: "devicetree@vger.kernel.org" , Rob Herring , linux-rockchip@lists.infradead.org Subject: Re: arm/rockchip.yaml - many separate entries instead of enums Date: Tue, 29 Mar 2022 22:54:37 +0200 Message-ID: <1681233.QkHrqEjB74@diego> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hey :-) , Am Dienstag, 29. März 2022, 19:05:24 CEST schrieb Krzysztof Kozlowski: > Hi Heiko, > > I found that Documentation/devicetree/bindings/arm/rockchip.yaml uses > pattern of one board per item in oneOf. > > This leads to quite big file, with many entries, although gives nice > description for each board. that was the original intention in doing it this way, preserving the normal readability while adding machine readability to it :-) > I find enum-based pattern, like FSL [1], much more readable and compact. > What do you think? I could re-organize the arm/rockchip.yaml, but I > don't want to mess with your preference. I do like the current way as it does only contains one way of doing it. As far as I can see, the fsl one has multiple types, like the one you pointed at, for a list of boards + one soc that works for the simple plethora of regular boards. But also additional types that do it similarly to Rockchip like the "i.MX6Q Advantech DMS-BA16 boards" directly below it. As we have both cases here as well, I really don't like this mix but instead really like to have only one approach, hence the one-entry-per-board-family we do in rockchip.yaml [2] For human readability I really do consider having _one_ way of describing boards superior to mixing approaches and the automated parsing doesn't care, as long as the syntax is correct ;-) Heiko [2] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/arm/rockchip.yaml#L507 > [1] > https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/arm/fsl.yaml#L191 > > Best regards, > Krzysztof >