From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9779EB64D9 for ; Fri, 30 Jun 2023 02:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229742AbjF3CMQ (ORCPT ); Thu, 29 Jun 2023 22:12:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjF3CMP (ORCPT ); Thu, 29 Jun 2023 22:12:15 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CEA2D56; Thu, 29 Jun 2023 19:12:13 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 19FE824E245; Fri, 30 Jun 2023 10:12:07 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 10:12:07 +0800 Received: from [192.168.125.93] (183.27.97.206) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 10:12:06 +0800 Message-ID: <16813f18-2188-ad9d-9c06-6bbc845b9d99@starfivetech.com> Date: Fri, 30 Jun 2023 10:12:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 5/5] riscv: dts: starfive: Add JH7110 PWM-DAC support Content-Language: en-US To: Krzysztof Kozlowski , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Walker Chen" , Xingyu Wu , Emil Renner Berthing CC: , , , References: <20230626110909.38718-1-hal.feng@starfivetech.com> <20230626110909.38718-6-hal.feng@starfivetech.com> <2a0154ec-7949-f1b1-760f-3ba64d2cff3f@linaro.org> From: Hal Feng In-Reply-To: <2a0154ec-7949-f1b1-760f-3ba64d2cff3f@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.206] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 26 Jun 2023 17:37:35 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add PWM-DAC support for StarFive JH7110 SoC. >> >> Signed-off-by: Hal Feng >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 50 +++++++++++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 13 +++++ >> 2 files changed, 63 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 19b5954ee72d..5ca66a65e722 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -36,6 +36,34 @@ gpio-restart { >> gpios = <&sysgpio 35 GPIO_ACTIVE_HIGH>; >> priority = <224>; >> }; >> + >> + pwmdac_dit: pwmdac-dit { >> + compatible = "starfive,jh7110-pwmdac-dit"; >> + #sound-dai-cells = <0>; >> + }; >> + >> + sound { >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "StarFive-PWMDAC-Sound-Card"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + simple-audio-card,dai-link@0 { >> + reg = <0>; >> + format = "left_j"; >> + bitclock-master = <&sndcpu0>; >> + frame-master = <&sndcpu0>; >> + status = "okay"; > > Drop OK. > >> + >> + sndcpu0: cpu { >> + sound-dai = <&pwmdac>; >> + }; >> + >> + codec { >> + sound-dai = <&pwmdac_dit>; > > You said it is a transmitter, not a codec... It is a dummy codec, also known as a dummy transmitter. Best regards, Hal