From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4077C2D0E4 for ; Tue, 17 Nov 2020 09:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F48124199 for ; Tue, 17 Nov 2020 09:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbgKQJYW (ORCPT ); Tue, 17 Nov 2020 04:24:22 -0500 Received: from foss.arm.com ([217.140.110.172]:52698 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgKQJYV (ORCPT ); Tue, 17 Nov 2020 04:24:21 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A35A1042; Tue, 17 Nov 2020 01:24:20 -0800 (PST) Received: from [10.57.25.49] (unknown [10.57.25.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BDB53F719; Tue, 17 Nov 2020 01:24:15 -0800 (PST) Subject: Re: [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA To: "Rafael J. Wysocki" Cc: Linux Kernel Mailing List , Linux PM , "open list:DOCUMENTATION" , "devicetree@vger.kernel.org" , Linux ARM , Rob Herring , Amit Kucheria , Jonathan Corbet , Daniel Lezcano , Dietmar Eggemann , Morten Rasmussen , Quentin Perret , Doug Anderson , Matthias Kaehlcke , "Nayak, Rajendra" , Sudeep Holla , Viresh Kumar , Stephen Boyd , Nishanth Menon References: <20201103090600.29053-1-lukasz.luba@arm.com> <9382ea70-cc50-7b78-f5de-716678bdefbf@arm.com> From: Lukasz Luba Message-ID: <1685b7c8-e6bb-fc3b-c2ff-5c87c35610f0@arm.com> Date: Tue, 17 Nov 2020 09:24:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/10/20 7:32 PM, Rafael J. Wysocki wrote: > On Wed, Nov 4, 2020 at 11:58 AM Lukasz Luba wrote: >> >> Hi Rafael, >> >> On 11/3/20 9:05 AM, Lukasz Luba wrote: >>> Hi all, >>> >>> The Energy Model supports power values expressed in an abstract scale. >>> This has an impact on Intelligent Power Allocation (IPA) and should be >>> documented properly. Kernel sub-systems like EAS, IPA and DTPM >>> (new comming PowerCap framework) would use the new flag to capture >>> potential miss-configuration where the devices have registered different >>> power scales, thus cannot operate together. >>> >>> There was a discussion below v2 of this patch series, which might help >>> you to get context of these changes [2]. >>> >>> The agreed approach is to have the DT as a source of power values expressed >>> always in milli-Watts and the only way to submit with abstract scale values >>> is via the em_dev_register_perf_domain() API. >>> >>> Changes: >>> v4: >>> - change bool to int type for 'miliwatts' in struct em_perf_domain >>> (suggested by Quentin) >>> - removed one sentence from patch 2/4 in IPA doc power_allocator.rst >>> (suggested by Quentin) >>> - added reviewed-by from Quentin to 1/4, 3/4, 4/4 patches >> >> There was no major objections in the v3 and this v4 just addressed >> minor comments. The important discussions mostly happen in v2. >> >> Could you take the patches via your tree, please? > > Applied as 5.11 material, thanks! > Thank you Rafael! Regards, Lukasz