From: Rob Herring <robh@kernel.org>
To: Tommaso Merciai <tomm.merciai@gmail.com>
Cc: martin.hecht@avnet.eu, linux-media@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
linuxfancy@googlegroups.com,
"Marco Felsch" <m.felsch@pengutronix.de>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
jacopo.mondi@ideasonboard.com, michael.roeder@avnet.eu,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Mikhail Rudenko" <mike.rudenko@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
"Nicholas Roth" <nicholas@rothemail.net>,
"Mark Brown" <broonie@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Shawn Tu" <shawnx.tu@intel.com>,
laurent.pinchart@ideasonboard.com,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>
Subject: Re: [PATCH v3 2/3] media: dt-bindings: alvium: add document YAML binding
Date: Tue, 06 Jun 2023 10:31:09 -0600 [thread overview]
Message-ID: <168606906960.978218.13949721603779503286.robh@kernel.org> (raw)
In-Reply-To: <20230606155416.260941-3-tomm.merciai@gmail.com>
On Tue, 06 Jun 2023 17:54:03 +0200, Tommaso Merciai wrote:
> Add documentation of device tree in YAML schema for the ALVIUM
> Camera from Allied Vision Inc.
>
> References:
> - https://www.alliedvision.com/en/products/embedded-vision-solutions
>
> Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
> ---
> Changes since v1:
> - Fixed build error as suggested by RHerring bot
>
> Changes since v2:
> - Fixed License as suggested by KKozlowski/CDooley
> - Removed rotation property as suggested by CDooley/LPinchart
> - Fixed example node name as suggested by CDooley
> - Fixed title as suggested by LPinchart
> - Fixed compatible name as suggested by LPinchart
> - Removed clock as suggested by LPinchart
> - Removed gpios not as suggested by LPinchart
> - Renamed property name streamon-delay into alliedvision,lp2hs-delay-us
> - Fixed vendor prefix, unit append as suggested by KKozlowski
> - Fixed data-lanes
> - Fixed blank space + example indentation (from 6 -> 4 space) as suggested by KKozlowski
> - Dropped status into example as suggested by KKozlowski
> - Added vcc-ext-in supply as suggested by LPinchart
> - Dropped pinctrl into example as suggested by LPinchart
>
> .../media/i2c/alliedvision,alvium-csi2.yaml | 93 +++++++++++++++++++
> 1 file changed, 93 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/media/i2c/alliedvision,alvium-csi2.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/media/i2c/alliedvision,alvium-csi2.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606155416.260941-3-tomm.merciai@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-06-06 16:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230606155416.260941-1-tomm.merciai@gmail.com>
2023-06-06 15:54 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Add prefix alliedvision Tommaso Merciai
2023-06-06 16:29 ` Laurent Pinchart
2023-06-06 18:02 ` Conor Dooley
2023-06-07 6:55 ` Krzysztof Kozlowski
2023-06-06 15:54 ` [PATCH v3 2/3] media: dt-bindings: alvium: add document YAML binding Tommaso Merciai
2023-06-06 16:31 ` Rob Herring [this message]
2023-06-06 16:36 ` Laurent Pinchart
2023-06-06 18:07 ` Conor Dooley
2023-06-06 18:17 ` Laurent Pinchart
2023-06-06 18:23 ` Conor Dooley
2023-06-07 7:16 ` Tommaso Merciai
2023-06-07 7:14 ` Tommaso Merciai
2023-06-07 7:21 ` Laurent Pinchart
2023-06-07 11:27 ` Tommaso Merciai
2023-06-07 7:11 ` Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168606906960.978218.13949721603779503286.robh@kernel.org \
--to=robh@kernel.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxfancy@googlegroups.com \
--cc=m.felsch@pengutronix.de \
--cc=martin.hecht@avnet.eu \
--cc=mchehab@kernel.org \
--cc=michael.roeder@avnet.eu \
--cc=mike.rudenko@gmail.com \
--cc=nicholas@rothemail.net \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnx.tu@intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).