From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3817C7EE2C for ; Tue, 6 Jun 2023 18:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239122AbjFFSwb (ORCPT ); Tue, 6 Jun 2023 14:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239123AbjFFSw0 (ORCPT ); Tue, 6 Jun 2023 14:52:26 -0400 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A114172D for ; Tue, 6 Jun 2023 11:52:23 -0700 (PDT) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-33d0b7114a9so207465ab.2 for ; Tue, 06 Jun 2023 11:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686077542; x=1688669542; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=g7ySt9S9+1IxxubjMQVvExdjJhwIi1vFWRB5NUPlv8I=; b=R6qsPgBZ5nstP5gOkyLFlBaOW6Oy8hDUwDQ9xk8ynaH4c/nK8GEJEem6hOgJgnRv4z 8hkSrajZMT/nB4Ai52hdoENyNL5RBsuhxGIwbFdzlEmixiIG3vWtuILghxTnaPP0lY73 XWfgaltuQVfT8SjGguwBilMjOoDPPI7S1jnvp4Nlx1KcKrreh36rTu5LBN5edmxbB5tA BptY2t6IhVdw7Nsny4QyaQTAQQ5+nyUIuO8vmEnTbXrAAZgWkbOMjnKBlu1QCzb0KFt6 O6lQ3iZqWcVwlGGRUZ/jb40ljcGvBUIwL3BbpBFuuW1f6+QzNw6bLLsKLE6jBGrZSizY Dl9g== X-Gm-Message-State: AC+VfDxawj7+1J/palHxZoChHCjwszNWpn+Ojl5IqDccheGXkhsM60cD JlERnZG2c+uacvR+9SiUqw== X-Google-Smtp-Source: ACHHUZ4HJV+ykjkCC5jDPohhB66SaTHJdLRvLFc/91wp0Ivo7MIooI5I9Se42TKUUDfgsbWsoFcHCg== X-Received: by 2002:a92:dc86:0:b0:33d:7144:7b98 with SMTP id c6-20020a92dc86000000b0033d71447b98mr4144016iln.3.1686077542651; Tue, 06 Jun 2023 11:52:22 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id u26-20020a02cbda000000b0040fc9317650sm1148641jaq.62.2023.06.06.11.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 11:52:22 -0700 (PDT) Received: (nullmailer pid 1468447 invoked by uid 1000); Tue, 06 Jun 2023 18:52:00 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Rob Herring To: Miquel Raynal Cc: Krzysztof Kozlowski , Tudor Ambarus , Michael Walle , Pratyush Yadav , Thomas Petazzoni , linux-mtd@lists.infradead.org, Vignesh Raghavendra , Richard Weinberger , devicetree@vger.kernel.org, Chris Packham , Rob Herring , Vadivel Murugan In-Reply-To: <20230606175246.190465-13-miquel.raynal@bootlin.com> References: <20230606175246.190465-1-miquel.raynal@bootlin.com> <20230606175246.190465-13-miquel.raynal@bootlin.com> Message-Id: <168607751649.1468346.12620524659551431762.robh@kernel.org> Subject: Re: [PATCH v2 12/17] dt-bindings: mtd: intel: Prevent NAND chip unevaluated properties Date: Tue, 06 Jun 2023 12:52:00 -0600 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 06 Jun 2023 19:52:41 +0200, Miquel Raynal wrote: > nand-ecc-mode is a generic property which may apply to any raw NAND > chip, it does not need to be listed in each controller > description. Instead, let's reference the raw NAND chip description file > which contains the property. The description contained > "additionalProperties: false" which is wrong as other properties such as > partitions might very well be added in the final .dts, and anyway needs > to be converted into "unexpectedProperties: false" to fit the property > change new requirements. > > Cc: Vadivel Murugan > Signed-off-by: Miquel Raynal > --- > Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.example.dtb: nand-controller@e0f00000: nand@0: False schema does not allow {'reg': [[0]], 'nand-ecc-mode': ['hw']} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.example.dtb: nand-controller@e0f00000: nand@0: Unevaluated properties are not allowed ('nand-ecc-mode' was unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/intel,lgm-ebunand.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230606175246.190465-13-miquel.raynal@bootlin.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.