From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472C5EB64D9 for ; Thu, 15 Jun 2023 05:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbjFOFZ6 (ORCPT ); Thu, 15 Jun 2023 01:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbjFOFZ6 (ORCPT ); Thu, 15 Jun 2023 01:25:58 -0400 Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABA11715; Wed, 14 Jun 2023 22:25:56 -0700 (PDT) Received: by mail-io1-f46.google.com with SMTP id ca18e2360f4ac-77b210292c5so124553939f.1; Wed, 14 Jun 2023 22:25:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686806756; x=1689398756; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+8XvSUs++s8SCtB1NRYbEUottu+u+FOeTtSd2dCMIl4=; b=OPkulilgoaeNsC2AHA9eVv/EXrX6X5PZ8ytnih9JqTnme2wS0h2q0bnHiSQLgyHI08 DQrZxqJtsYUfa+/6qPn2G+Wc5YbBbH9LHL1QZWPBCq3r9tGSGT95/iC9hiTQM0L22NFo aT0EBtsQmhKGi1k7Mbr9AxihU/MKwskuSWMaxOOLEwGyrroqONj+yELXQhMb5MkM1n8B Ho63N5933fERI/xdsg7/1xuReBS9SDITWC1P0wE5TV7jSLmfJs3da+hF8QB+l+ihqEzW FR4fgvEaE3wtt1qyu+oVxIQKNxSdoauYB0dSYbpZjC5mWZ1Z3+6DOAAI+nKEtNEuiF7t xqHA== X-Gm-Message-State: AC+VfDyNavSbCf2Sf1BO/6vnDKTHxTP62p6FezO+v9QAvd4N+OUPAUZJ rMpXmZij9+xFAOkSRJgZpg== X-Google-Smtp-Source: ACHHUZ5QDYc4xJaaMz9XXahg84pWJ2bqFrHsJ0QmkRBa48Qll6rYChqgYKtFR7u+3VZBUkMpS5dA8w== X-Received: by 2002:a5d:8513:0:b0:74c:c6ed:6de with SMTP id q19-20020a5d8513000000b0074cc6ed06demr17005254ion.12.1686806755909; Wed, 14 Jun 2023 22:25:55 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id k8-20020a02c768000000b00416650ba62esm5415546jao.76.2023.06.14.22.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 22:25:55 -0700 (PDT) Received: (nullmailer pid 3823193 invoked by uid 1000); Thu, 15 Jun 2023 05:25:53 -0000 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: Rob Herring To: Chris Packham Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, vigneshr@ti.com, miquel.raynal@bootlin.com, krzysztof.kozlowski+dt@linaro.org, richard@nod.at, Vadym Kochan , linux-arm-kernel@lists.infradead.org, gregory.clement@bootlin.com, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20230615040447.3484564-4-chris.packham@alliedtelesis.co.nz> References: <20230615040447.3484564-1-chris.packham@alliedtelesis.co.nz> <20230615040447.3484564-4-chris.packham@alliedtelesis.co.nz> Message-Id: <168680675314.3823167.2320130564713925420.robh@kernel.org> Subject: Re: [PATCH v9 3/3] dt-bindings: mtd: marvell-nand: Convert to YAML DT scheme Date: Wed, 14 Jun 2023 23:25:53 -0600 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 15 Jun 2023 16:04:47 +1200, Chris Packham wrote: > From: Vadym Kochan > > Switch the DT binding to a YAML schema to enable the DT validation. > > The text binding didn't mention it as a requirement but existing usage > has > > compatible = "marvell,armada-8k-nand-controller", > "marvell,armada370-nand-controller"; > > so the YAML allows this in addition to the individual compatible values. > > There was also an incorrect reference to dma-names being "rxtx" where > the driver and existing device trees actually use dma-names = "data" so > this is corrected in the conversion. > > Signed-off-by: Vadym Kochan > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v9: > - depend on series from Miquel > https://lore.kernel.org/linux-mtd/20230606175246.190465-1-miquel.raynal@bootlin.com/ > - enforce minimum/maximum for nand-rb > - move required: block for controller > - move unevaluatedProperties: for nand chip > - remove label, partitions and nand-on-flash-bbt which are covered by > generic schema > > Changes in v8: > - Mark deprecated compatible values as such > - Allow "marvell,armada-8k-nand-controller" without > "marvell,armada370-nand-controller" > - Make dma-names usage reflect reality > - Update commit message > > Changes in v7: > - Restore "label" and "partitions" properties (should be picked up via > nand-controller.yaml but aren't) > - Add/restore nand-on-flash-bbt and nand-ecc-mode which aren't covered > by nand-controller.yaml. > - Use "unevalautedProperties: false" > - Corrections for clock-names, dma-names, nand-rb and nand-ecc-strength > - Add pxa3xx-nand-controller example > > Changes in v6: > - remove properties covered by nand-controller.yaml > - add example using armada-8k compatible > > earlier changes: > > v5: > 1) Get back "label" and "partitions" properties but without > ref to the "partition.yaml" which was wrongly used. > > 2) Add "additionalProperties: false" for nand@ because all possible > properties are described. > > v4: > 1) Remove "label" and "partitions" properties > > 2) Use 2 clocks for A7K/8K platform which is a requirement > > v3: > 1) Remove txt version from the MAINTAINERS list > > 2) Use enum for some of compatible strings > > 3) Drop: > #address-cells > #size-cells: > > as they are inherited from the nand-controller.yaml > > 4) Add restriction to use 2 clocks for A8K SoC > > 5) Dropped description for clock-names and extend it with > minItems: 1 > > 6) Drop description for "dmas" > > 7) Use "unevalautedProperties: false" > > 8) Drop quites from yaml refs. > > 9) Use 4-space indentation for the example section > > v2: > 1) Fixed warning by yamllint with incorrect indentation for compatible list > > .../bindings/mtd/marvell,nand-controller.yaml | 218 ++++++++++++++++++ > .../devicetree/bindings/mtd/marvell-nand.txt | 126 ---------- > MAINTAINERS | 1 - > 3 files changed, 218 insertions(+), 127 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml > delete mode 100644 Documentation/devicetree/bindings/mtd/marvell-nand.txt > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml: Error in referenced schema matching $id: http://devicetree.org/schemas/mtd/raw-nand-chip.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.example.dtb: nand-controller@d0000: nand@0: False schema does not allow {'reg': [[0]], 'label': ['main-storage'], 'nand-rb': [[0]], 'nand-ecc-mode': ['hw'], 'marvell,nand-keep-config': True, 'nand-on-flash-bbt': True, 'nand-ecc-strength': [[4]], 'nand-ecc-step-size': [[512]], 'partitions': {'compatible': ['fixed-partitions'], '#address-cells': [[1]], '#size-cells': [[1]], 'partition@0': {'label': ['Rootfs'], 'reg': [[0, 1073741824]]}}} from schema $id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.example.dtb: nand-controller@d0000: nand@0: Unevaluated properties are not allowed ('label', 'nand-on-flash-bbt', 'partitions' were unexpected) from schema $id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.example.dtb: nand-controller@720000: nand@0: False schema does not allow {'reg': [[0]], 'label': ['main-storage'], 'nand-rb': [[0]], 'nand-ecc-mode': ['hw'], 'nand-ecc-strength': [[8]], 'nand-ecc-step-size': [[512]]} from schema $id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.example.dtb: nand-controller@720000: nand@0: Unevaluated properties are not allowed ('label' was unexpected) from schema $id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/marvell,nand-controller.example.dtb: nand-controller@43100000: nand@0: False schema does not allow {'reg': [[0]], 'nand-rb': [[0]], 'nand-ecc-mode': ['hw'], 'marvell,nand-keep-config': True} from schema $id: http://devicetree.org/schemas/mtd/marvell,nand-controller.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230615040447.3484564-4-chris.packham@alliedtelesis.co.nz The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.