From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1D2CC001DF for ; Mon, 17 Jul 2023 11:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbjGQLgJ (ORCPT ); Mon, 17 Jul 2023 07:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjGQLgI (ORCPT ); Mon, 17 Jul 2023 07:36:08 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D92E4C; Mon, 17 Jul 2023 04:36:07 -0700 (PDT) Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AC0DD16C4; Mon, 17 Jul 2023 13:35:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1689593710; bh=Q3mYfdnpaLKlY8/jxmRm80QstU9e0PZzEci91ZZE1j4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=D34b2nk3MBeIsD4Hh9go1cz7KYgQfaVb0QwyTeWrvQudhj3fcvsR86k18n5c2Eh/a 11cp7FnDEwboNqdfvQSni7J+NuSf4nawSesO0QfLQ1Tb/Qq/1vhrC/00e2IYaQomU7 muczhfhcRx636pqbzTWg6NH753X76UJuCpEmbpUo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230714174545.4056287-1-robh@kernel.org> References: <20230714174545.4056287-1-robh@kernel.org> Subject: Re: [PATCH] drm: Explicitly include correct DT includes From: Kieran Bingham Cc: devicetree@vger.kernel.org, Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org To: Abhinav Kumar , Alain Volmat , Alexandre Torgue , Alim Akhtar , Alyssa Rosenzweig , Andrzej Hajda , AngeloGioacchino Del Regno , Artur Weber , Baolin Wang , Broadcom internal kernel review list , Chen-Yu Tsai , Christian Gmeiner , Chun-Kuang Hu , Chunyan Zhang , Daniel Vetter , David Airlie , Dmitry Baryshkov , Emma Anholt , Fabio Estevam , Florian Fainelli , Guido =?utf-8?q?G=C3=BCnther?= , Heiko =?utf-8?q?St=C3=BCbner?= , Icenow y Zheng , Inki Dae , Jagan Teki , Javier Martinez Canillas , Jernej Skrabec , Jerome Brunet , Jerry Han , Jianhua Lu , John Stultz , Jonas Karlman , Jonathan Hunter , Jyri Sarha , Kevin Hilman , Krzysztof Kozlowski , Kyungmin Park , Laurent Pinchart , Laurentiu Palcu , Linus Walleij , Liu Ying , Liviu Dudau , Lucas Stach , Maarten Lankhorst , Marek Szyprowski , Marek Vasut , Marijn Suijten , Martin Blumenstingl , Matthias Brugger , Maxime Coquelin , Maxime Ripard , Mikko Perttunen , NXP Linux Team , Neil Armstrong , Oleksandr Andrushchenko , Ondrej Jirman , Orson Zhai , Paul Cercueil , Paul Kocialkowski , Pengutronix Kernel Team , Philipp Zabel , Philippe Cornu , Purism Kernel Team , Qiang Yu , Raphael Gallais-Pou , Rob Clark , Rob Herring , Robert Foss , Russell King , Sam Ravnborg , Samuel Holland , Sandy Huang , Sascha Hauer , Sean Paul , Seung-Woo Kim , Shawn Guo , Stefan Agner , Steven Price , Sumit Semwal , Thierry Reding , Thomas Zimmermann , Tian Tao , Tomeu Vizoso , Tomi Valkeinen , Xinliang Liu , Xinwei Kong , Yannick Fertre , Yongqin Liu Date: Mon, 17 Jul 2023 12:35:59 +0100 Message-ID: <168959375926.3515353.7529038208688306372@Monstersaurus> User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Quoting Rob Herring (2023-07-14 18:45:34) > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. >=20 > Signed-off-by: Rob Herring > drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 2 +- > drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 2 ++ > drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c | 1 + > drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 1 - > drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 1 - For drivers/gpu/drm/renesas/rcar-du/ > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/= drm/renesas/rcar-du/rcar_du_drv.c > index 1ffde19cb87f..3904b0cca814 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c > @@ -12,7 +12,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c b/drivers/gpu/= drm/renesas/rcar-du/rcar_du_kms.c > index adfb36b0e815..9ff4537c26c8 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c > @@ -20,8 +20,10 @@ > =20 > #include > #include > +#include > #include > #include > +#include > #include > =20 > #include "rcar_du_crtc.h" > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c b/drivers/gpu/= drm/renesas/rcar-du/rcar_du_vsp.c > index 45c05d0ffc70..9cbb5e6e2cba 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c b/drivers/gp= u/drm/renesas/rcar-du/rcar_mipi_dsi.c > index e10e4d4b89a2..db2e6f16f954 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/g= pu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > index aa95b85a2964..8048bdca2d6c 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > #include Reviewed-by: Kieran Bingham