Re: 回复: [PATCH v2 1/2] dt-bindings: PCI: update CIX Sky1 PCIe Root Complex bindings

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/03/2026 03:31, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for your comments
> 
>> EXTERNAL EMAIL
>>
>> On 10/03/2026 07:53, Gary Yang wrote:
>>> add power-domains and power-domain-names property
>>
>> Why? Please write complete sentences explaining why you are doing this.
>>
> 
> Sorry, I did not describe in detail.
> 
> The Sky1 PCIe controller sits in a power domain that must be enabled before the controller can be accessed.
> Describe the power-domains property so that DTS files can reference the correct power domain provider.
> 
>>>
>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>> ---
>>>  .../devicetree/bindings/pci/cix,sky1-pcie-host.yaml         | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>> b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>>> index b910a42e0843..1d8ee8310588 100644
>>> --- a/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>>> @@ -38,6 +38,12 @@ properties:
>>>    ranges:
>>>      maxItems: 3
>>>
>>> +  power-domains:
>>> +    minItems: 1
>>> +
>>> +  power-domain-names:
>>> +    minItems: 1
>>
>> There is no such syntax. Open any existing bindinh.
>>
> 
> Sorry, They come from Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml

There is no such syntax there.

Just open the file.


> 
> Execute the two commands below before submit patch every time.
> 
> make O=$OUTKNL dt_binding_check
> make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=cix,sky1-pcie-host.yaml
> 
> we don't find any warning or error. So we think all is ok.

No, because there is no such code nowhere. Please take other bindings as
an example. You miss here maxItems.

Best regards,
Krzysztof