From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>, Linus Walleij <linus.walleij@linaro.org>
Cc: JJLIU0@nuvoton.com, KWLIU@nuvoton.com, brgl@bgdev.pl,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 3/3] dt-bindings: gpio: Add Nuvoton NPCM750 serial I/O expansion interface(SGPIO)
Date: Tue, 15 Nov 2022 10:58:18 +0100 [thread overview]
Message-ID: <168ed6e6-21bf-f034-504e-6da36842f4bc@linaro.org> (raw)
In-Reply-To: <CAKUZ0+FD=x8s+vqUpYwsuRUw-yTHQjtTFzWDwW=d4k8X1x1LoQ@mail.gmail.com>
On 15/11/2022 10:21, Jim Liu wrote:
> Hi Linus and Krzysztof
>
> Thanks for your understanding and your suggestion.
> I will follow your suggestion to modify the yaml file.
> -> nuvoton,input-ngpios = <...>
> -> nuvoton,output-ngpios = <...>
>
> And I don't think the node name needs to use gpio.
> because it's not a general gpio, so I reference aspeed dts and use sgpio.
> Could I use the sgpio node name or could you provide some suggestions?
Aspeed DTS has poor code readability (not following several common DT
conventions), so using it as an example or argument is not correct
approach. Nodes have name "gpio" for GPIO controllers or one of
pinctrl.yaml for pin controllers.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-15 9:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:28 [PATCH v2 0/3] Support Nuvoton NPCM750 SGPIO Jim Liu
2022-11-08 9:28 ` [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver Jim Liu
2022-11-08 13:02 ` Linus Walleij
2022-11-08 18:17 ` kernel test robot
2022-11-12 22:52 ` kernel test robot
2022-11-08 9:28 ` [PATCH v2 2/3] arm: dts: nuvoton: npcm7xx: add sgpio node Jim Liu
2022-11-08 15:24 ` Krzysztof Kozlowski
2022-11-08 9:28 ` [PATCH v2 3/3] dt-bindings: gpio: Add Nuvoton NPCM750 serial I/O expansion interface(SGPIO) Jim Liu
2022-11-08 12:54 ` Rob Herring
2022-11-08 12:59 ` Linus Walleij
2022-11-08 15:21 ` Krzysztof Kozlowski
2022-11-09 9:14 ` Linus Walleij
2022-11-11 9:30 ` Jim Liu
2022-11-11 14:20 ` Linus Walleij
2022-11-14 8:38 ` Jim Liu
2022-11-14 10:13 ` Linus Walleij
2022-11-15 9:21 ` Jim Liu
2022-11-15 9:58 ` Krzysztof Kozlowski [this message]
2022-11-16 7:57 ` Jim Liu
2022-11-15 9:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168ed6e6-21bf-f034-504e-6da36842f4bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jim.t90615@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).