From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30880C4332F for ; Tue, 15 Nov 2022 09:58:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232761AbiKOJ63 (ORCPT ); Tue, 15 Nov 2022 04:58:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237831AbiKOJ6X (ORCPT ); Tue, 15 Nov 2022 04:58:23 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B75915735 for ; Tue, 15 Nov 2022 01:58:22 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id p8so23602516lfu.11 for ; Tue, 15 Nov 2022 01:58:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6juo/G7lsQvTKk0wwfl/N9U9Zrf2YS9a6XxIt2w0Gz4=; b=Wehg82bsZeGgL44LnWaLKYNuB7qTx/GrZyqn00wtkPxp1Af2/5Xez9E68dlhiHh30A Qp2Tf+tBvu/HHAbGjX+BbvZo5lYjEF+UxPXkiAREzX5UG3fW9JPAKGzkUFsgrIhjzNH+ u00dz4b9InlHCrYL6+VtIi76gQYLRsDhbtZ07PS7prBJUzCQQlex8s1PQ2qE3J0KySEy WM9YBLig2uO9dICchdYjkQ7leE3wo3xQPKKiNUXN2p3+391hcOyOvWQJzsqukONWXqhN yvGrwUNQkaMrpLaBB3Vz+GccTrTsgaWbdnAGk67rEOTtCX0RMiOjEBdSJq48k8n9CU/M U7Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6juo/G7lsQvTKk0wwfl/N9U9Zrf2YS9a6XxIt2w0Gz4=; b=qKQ3/tIqQq1tE0QVktRCe58KXIDC1WVdAw7gmk77nGwWzH5f5DthpfX0ocEIWH1iJk 6jfGLqQoeLth5bTl0nI7rHMPLldiWr9X0yl3r6EAq5IsfaS2j3+53x6Ykdl19ll51JNk fhd9HVEThPoZLylU+QJO9oH8+X8flzP3j/8U+RnumbaOW/Q0Uxcxx0QEP4djGJab0SV7 JzJMFZmX/vOr6thJZIEwoDBK7joOBX6gzb76Uz07u9hxV91N2lNY27AmCzXr6h7dct0e nbKA7ck701PQyLDLklDQjo9+UUWUTKNOZZ1seW7+9Z6l35Y5umb9fyuZictiKw4TbEbp Z7hA== X-Gm-Message-State: ANoB5pn//GBNYJqSWz5Fk7jboJ1lISFNFUyCBv7dzqXGT0neTRJhfYAi gtgjhIFOE/vRD1BTQTfg02WJLA== X-Google-Smtp-Source: AA0mqf5ZDNZjWdGk7sBPAGwBXO0zxQiHOKP9nStDRm0y7OArlh4UHkBE1J+m5ZYnT1T8HbqaDP5o+g== X-Received: by 2002:ac2:55a9:0:b0:4a4:6256:a888 with SMTP id y9-20020ac255a9000000b004a46256a888mr5067978lfg.46.1668506300450; Tue, 15 Nov 2022 01:58:20 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id i25-20020a2e8099000000b0026bca725cd0sm2436205ljg.39.2022.11.15.01.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 01:58:19 -0800 (PST) Message-ID: <168ed6e6-21bf-f034-504e-6da36842f4bc@linaro.org> Date: Tue, 15 Nov 2022 10:58:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/3] dt-bindings: gpio: Add Nuvoton NPCM750 serial I/O expansion interface(SGPIO) Content-Language: en-US To: Jim Liu , Linus Walleij Cc: JJLIU0@nuvoton.com, KWLIU@nuvoton.com, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org References: <20221108092840.14945-1-JJLIU0@nuvoton.com> <20221108092840.14945-4-JJLIU0@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/11/2022 10:21, Jim Liu wrote: > Hi Linus and Krzysztof > > Thanks for your understanding and your suggestion. > I will follow your suggestion to modify the yaml file. > -> nuvoton,input-ngpios = <...> > -> nuvoton,output-ngpios = <...> > > And I don't think the node name needs to use gpio. > because it's not a general gpio, so I reference aspeed dts and use sgpio. > Could I use the sgpio node name or could you provide some suggestions? Aspeed DTS has poor code readability (not following several common DT conventions), so using it as an example or argument is not correct approach. Nodes have name "gpio" for GPIO controllers or one of pinctrl.yaml for pin controllers. Best regards, Krzysztof