From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Wayne Chang <waynec@nvidia.com>,
Benson Leung <bleung@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v2] dt-bindings: usb: connector: disallow additional properties
Date: Thu, 27 Jul 2023 11:09:51 -0600 [thread overview]
Message-ID: <169047762815.1817455.10294109902961650429.robh@kernel.org> (raw)
In-Reply-To: <20230725102325.76336-1-krzysztof.kozlowski@linaro.org>
On Tue, 25 Jul 2023 12:23:25 +0200, Krzysztof Kozlowski wrote:
> USB connector bindings is complete, thus no additional properties should
> be allowed. Add missing 'reg' property and change additionalProperties
> to false, so the schema will check for anything not unexpected. This
> also allows to drop the 'reg' from other bindings referencing the
> usb-connector.yaml and make it required.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes in v2:
> 1. Make usb-connector.yaml additionalProperties:false (Rob)
>
> v1:
> https://lore.kernel.org/all/20230723071105.40157-1-krzysztof.kozlowski@linaro.org/
> ---
> .../devicetree/bindings/chrome/google,cros-ec-typec.yaml | 6 ++----
> .../devicetree/bindings/connector/usb-connector.yaml | 5 ++++-
> .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 6 ------
> Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 6 ++----
> 4 files changed, 8 insertions(+), 15 deletions(-)
>
I didn't not fix the double negative and applied, thanks! ;)
next prev parent reply other threads:[~2023-07-27 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 10:23 [PATCH v2] dt-bindings: usb: connector: disallow additional properties Krzysztof Kozlowski
2023-07-25 10:35 ` Krzysztof Kozlowski
2023-07-27 17:09 ` Rob Herring [this message]
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169047762815.1817455.10294109902961650429.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=robh+dt@kernel.org \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox