From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD26C0015E for ; Thu, 27 Jul 2023 17:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjG0RJ4 (ORCPT ); Thu, 27 Jul 2023 13:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231386AbjG0RJz (ORCPT ); Thu, 27 Jul 2023 13:09:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01444273C; Thu, 27 Jul 2023 10:09:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6054461E9F; Thu, 27 Jul 2023 17:09:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88213C433C7; Thu, 27 Jul 2023 17:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690477793; bh=Ky/oluIzHCEeuhuElQC9U6jY75TgLuPVRTngDIASvjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tV37aRq3EnmJ9lKNBvRBBvsJcANZbaisFqMyrl2Pi3tWcwWt18y03vrvM9t5FKEk1 Rl2/hqSCp3MrBcDSdvTjpGkYTdPmzmXE1L5NwlutDlmd9t4OfapibIqrZitsxA/HH/ /LG4PLGudZsTrq0m5vXi1bZ3nGWoSvAXkxCBC2o11jKkYuSQE1xiQjpMFLDO+bByk3 GoIz9nFIM43fkkTCYGgbdNWbDUp/AbK8mgEyboS+emJNvBbvKmjCxukQ22Pwd+5+2J +RNRSUTAAYm6mwokdZvQGBU3TQBa/uZqp80HzgudzpTStjB0DxSYsDWkPLybPYap7a 1zS3Q+X2UWTPA== Received: (nullmailer pid 1835903 invoked by uid 1000); Thu, 27 Jul 2023 17:09:51 -0000 Date: Thu, 27 Jul 2023 11:09:51 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Bjorn Andersson , Conor Dooley , Guenter Roeck , Prashant Malani , Andy Gross , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Konrad Dybcio , Wayne Chang , Benson Leung , Krzysztof Kozlowski , chrome-platform@lists.linux.dev Subject: Re: [PATCH v2] dt-bindings: usb: connector: disallow additional properties Message-ID: <169047762815.1817455.10294109902961650429.robh@kernel.org> References: <20230725102325.76336-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725102325.76336-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 25 Jul 2023 12:23:25 +0200, Krzysztof Kozlowski wrote: > USB connector bindings is complete, thus no additional properties should > be allowed. Add missing 'reg' property and change additionalProperties > to false, so the schema will check for anything not unexpected. This > also allows to drop the 'reg' from other bindings referencing the > usb-connector.yaml and make it required. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes in v2: > 1. Make usb-connector.yaml additionalProperties:false (Rob) > > v1: > https://lore.kernel.org/all/20230723071105.40157-1-krzysztof.kozlowski@linaro.org/ > --- > .../devicetree/bindings/chrome/google,cros-ec-typec.yaml | 6 ++---- > .../devicetree/bindings/connector/usb-connector.yaml | 5 ++++- > .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 6 ------ > Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 6 ++---- > 4 files changed, 8 insertions(+), 15 deletions(-) > I didn't not fix the double negative and applied, thanks! ;)