* [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
@ 2023-07-26 7:06 Eugen Hristev
2023-07-28 10:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Eugen Hristev @ 2023-07-26 7:06 UTC (permalink / raw)
To: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev
Cc: david.wu, heiko, krzysztof.kozlowski+dt, kernel, Eugen Hristev
The range and the defaults are specified in the description instead of
being specified in the schema.
Fix it by adding the default value in the `default` field and specifying
the range as `minimum` and `maximum`.
Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
changes in v2:
- also move the range as minimum/maximum in the schema
.../devicetree/bindings/net/rockchip-dwmac.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index bb943c96c196..70bbc4220e2a 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -92,12 +92,18 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle
tx_delay:
- description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
+ description: Delay value for TXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x30
rx_delay:
- description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
+ description: Delay value for RXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x10
phy-supply:
description: PHY regulator
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
2023-07-26 7:06 [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema Eugen Hristev
@ 2023-07-28 10:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-28 10:00 UTC (permalink / raw)
To: Eugen Hristev
Cc: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev, david.wu, heiko, krzysztof.kozlowski+dt, kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 26 Jul 2023 10:06:15 +0300 you wrote:
> The range and the defaults are specified in the description instead of
> being specified in the schema.
> Fix it by adding the default value in the `default` field and specifying
> the range as `minimum` and `maximum`.
>
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
>
> [...]
Here is the summary with links:
- [v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
https://git.kernel.org/netdev/net/c/5416d7925e6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-28 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 7:06 [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema Eugen Hristev
2023-07-28 10:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).