From: Rob Herring <robh@kernel.org>
To: werneazc@gmail.com
Cc: robh+dt@kernel.org,
Andre Werner <andre.werner@systec-electronic.com>,
linux-kernel@vger.kernel.org, jic23@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
lars@metafoo.de
Subject: Re: [PATCH v3 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038
Date: Mon, 16 Oct 2023 02:40:05 -0500 [thread overview]
Message-ID: <169744200549.1750835.3657501443373325472.robh@kernel.org> (raw)
In-Reply-To: <20231016070318.28355-1-andre.werner@systec-electronic.com>
On Mon, 16 Oct 2023 09:02:04 +0200, werneazc@gmail.com wrote:
> From: Andre Werner <andre.werner@systec-electronic.com>
>
> Add basic description for ADS7038 ADC devices.
> The devicetree adds the following device specific options:
>
> - average-samples: Program device's programmable average filter.
> - crc-enabled: Enable the CRC check for SPI transfers. Sadly, this
> option has currently no effect in the driver.
> - status-enabled: Enable the appending of the device's status on the
> measure value transmission.
> - gpio-controller: Sadly function not implemented yet in the driver.
>
> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
> ---
> v3
> - Delete ADS7138 compatible and comments.
> - Add options for CRC, status and average samples as well as
> gpio-controller.
> - Update example.
> - add regulator for digital IO voltage.
> ---
> .../bindings/iio/adc/ti,ads7038.yaml | 83 +++++++++++++++++++
> 1 file changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml: status-enabled: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads7038.yaml: crc-enabled: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231016070318.28355-1-andre.werner@systec-electronic.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-10-16 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 7:02 [PATCH v3 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038 werneazc
2023-10-16 7:18 ` Krzysztof Kozlowski
2023-10-16 7:38 ` Jonathan Cameron
2023-10-16 7:40 ` Rob Herring [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-15 18:32 werneazc
2023-10-15 19:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169744200549.1750835.3657501443373325472.robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.werner@systec-electronic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=werneazc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox