From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sinan Divarci <Sinan.Divarci@analog.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] drivers: hwmon: Add max31732 quad remote temperature sensor driver
Date: Wed, 14 Dec 2022 18:02:40 +0100 [thread overview]
Message-ID: <1697ded6-f04c-183b-4f92-ea4d5eb1c187@linaro.org> (raw)
In-Reply-To: <20221214142206.13288-2-Sinan.Divarci@analog.com>
On 14/12/2022 15:22, Sinan Divarci wrote:
> The MAX31732 is a multi-channel temperature sensor that monitors its own
> temperature and the temperatures of up to four external diodeconnected
> transistors.
Use subject prefixes matching the subsystem (git log --oneline -- ...).
There is no such prefix as "drivers".
I did not review the code, but it is easily visible that it does not
conform to Linux coding style wrapping at 80. Wrap at 80.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-14 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 14:22 [PATCH v2 0/3] hwmon: Add max31732 quad remote temperature sensor driver Sinan Divarci
2022-12-14 14:22 ` [PATCH v2 1/3] drivers: " Sinan Divarci
2022-12-14 17:02 ` Krzysztof Kozlowski [this message]
2022-12-14 17:24 ` Guenter Roeck
2022-12-15 8:32 ` Krzysztof Kozlowski
2022-12-29 15:38 ` Guenter Roeck
2022-12-14 14:22 ` [PATCH v2 2/3] docs: hwmon: add max31732 documentation Sinan Divarci
2022-12-29 15:39 ` Guenter Roeck
2022-12-14 14:22 ` [PATCH v2 3/3] dt-bindings: hwmon: Add bindings for max31732 Sinan Divarci
2022-12-14 17:00 ` Krzysztof Kozlowski
2022-12-29 15:52 ` Guenter Roeck
2022-12-29 16:39 ` Krzysztof Kozlowski
2022-12-29 18:30 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1697ded6-f04c-183b-4f92-ea4d5eb1c187@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Sinan.Divarci@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).