public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org,
	linux-kernel@vger.kernel.org, kernel@sberdevices.ru,
	andy.shevchenko@gmail.com, conor+dt@kernel.org, pavel@ucw.cz,
	krzysztof.kozlowski+dt@linaro.org, rockosov@gmail.com,
	robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints
Date: Wed, 01 Nov 2023 11:04:16 -0500	[thread overview]
Message-ID: <169885374980.409399.3653628333009308100.robh@kernel.org> (raw)
In-Reply-To: <20231101142445.8753-12-ddrokosov@salutedevices.com>


On Wed, 01 Nov 2023 17:24:45 +0300, Dmitry Rokosov wrote:
> AW200XX controllers have the capability to declare more than 0xf LEDs,
> therefore, it is necessary to accept LED names using an appropriate
> regex pattern.
> 
> The register offsets can be adjusted within the specified range, with
> the maximum value corresponding to the highest number of LEDs that can
> be connected to the controller.
> 
> Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
>  .../bindings/leds/awinic,aw200xx.yaml         | 64 +++++++++++++++++--
>  1 file changed, 58 insertions(+), 6 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@0: Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@1: Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/awinic,aw200xx.example.dtb: led-controller@3a: led@2: Unevaluated properties are not allowed ('reg' was unexpected)
	from schema $id: http://devicetree.org/schemas/leds/awinic,aw200xx.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231101142445.8753-12-ddrokosov@salutedevices.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2023-11-01 16:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 14:24 [PATCH v3 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 02/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-11-01 14:31   ` Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 03/11] dt-bindings: leds: aw200xx: introduce optional enable-gpios property Dmitry Rokosov
2023-11-06 14:53   ` Rob Herring
2023-11-01 14:24 ` [PATCH v3 04/11] leds: aw200xx: calculate dts property display_rows in the driver Dmitry Rokosov
2023-11-18 16:46   ` Andy Shevchenko
2023-11-01 14:24 ` [PATCH v3 05/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 06/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 07/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 08/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 09/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 10/11] dt-bindings: leds: awinic,aw200xx: add AW20108 device Dmitry Rokosov
2023-11-01 14:24 ` [PATCH v3 11/11] dt-bindings: leds: aw200xx: fix led pattern and add reg constraints Dmitry Rokosov
2023-11-01 15:31   ` Conor Dooley
2023-11-01 17:48     ` Dmitry Rokosov
2023-11-01 16:04   ` Rob Herring [this message]
2023-11-01 16:17     ` Conor Dooley
2023-11-01 17:44       ` Dmitry Rokosov
2023-11-02  0:17         ` Conor Dooley
2023-11-18 16:57 ` [PATCH v3 00/11] leds: aw200xx: several driver updates Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=169885374980.409399.3653628333009308100.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=ddrokosov@salutedevices.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@sberdevices.ru \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rockosov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox