From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DADD2230F; Fri, 10 Nov 2023 20:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 449B646BD; Fri, 10 Nov 2023 12:38:15 -0800 (PST) Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1f03d9ad89fso1281072fac.1; Fri, 10 Nov 2023 12:38:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648694; x=1700253494; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nDEOGTCwLGe8/AbnY8N0ixov4mA0V6wpnOxoAqQPSK4=; b=K61igppD8/5+4+6t+T+Zihghhp3L8MZpd66hxwSmTdWyPEaauzRRw1KnNTEH8kz6V7 +j9jXEjT4rTRoiIhhKFfpeesh4bm4eQT7sEw+1agwvTeP745bD3IQdExNKonQcU67kQm wGNcIoWGOdsAQkoqm1SvsxDjJH9hM3mAxvKqhTLSDeT/dY4Fekrp1Evd3iKsNprZPv7X Eo7E2lLgeGOfIT2cL7vmMVqsrbgXAoOkC9TfduALUmKBqWwvu2PdlxFCezQLVFVfBjh2 OCj2aOaXX84OfeOxiCqiOeLSAEwPXokixNCA+r8tV5XHpCL3QjaoYWpRIs0ZifHQEtDK OIWw== X-Gm-Message-State: AOJu0Yzd3FW4LKD1HV+TaZT0khLAchcNktLj/38N+p8WdG+RnHBexnuv ezQNi/F+QQCiyMxG86gj9g== X-Google-Smtp-Source: AGHT+IFVVQE4BI8cOz3AIQYw2pXVqurA/tQ+STytYpdzYk+6P+Wjdqy5vAj94WGd/H3Kxm+R2FQFzQ== X-Received: by 2002:a05:6870:d1c2:b0:1ea:14eb:b741 with SMTP id b2-20020a056870d1c200b001ea14ebb741mr343191oac.54.1699648694529; Fri, 10 Nov 2023 12:38:14 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y4-20020a056870a34400b001e9ce1b5e8fsm59655oak.15.2023.11.10.12.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:38:13 -0800 (PST) Received: (nullmailer pid 390527 invoked by uid 1000); Fri, 10 Nov 2023 20:38:11 -0000 Date: Fri, 10 Nov 2023 14:38:11 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: David Airlie , Andi Shyti , Lars-Peter Clausen , Alexandre Belloni , linux-iio@vger.kernel.org, Linus Walleij , Maxime Ripard , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tomasz Figa , Greg Kroah-Hartman , Rob Herring , Maarten Lankhorst , Thierry Reding , alsa-devel@alsa-project.org, Ulf Hansson , linux-rtc@vger.kernel.org, Sam Protsenko , Krzysztof Kozlowski , Jaehoon Chung , Lee Jones , Jiri Slaby , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Conor Dooley , Liam Girdwood , linux-mmc@vger.kernel.org, Jonathan Cameron , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, Mark Brown , linux-i2c@vger.kernel.org, Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Sylwester Nawrocki , Alessandro Zummo , linux-serial@vger.kernel.org, Daniel Vetter , Alim Akhtar Subject: Re: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC Message-ID: <169964869116.390473.6961652258456026108.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> On Wed, 08 Nov 2023 11:43:28 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++- > .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > Acked-by: Rob Herring