From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012413B293; Fri, 10 Nov 2023 20:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C95861727; Fri, 10 Nov 2023 12:40:53 -0800 (PST) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1efa01323b4so1410849fac.3; Fri, 10 Nov 2023 12:40:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648853; x=1700253653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F0iJFdRqfvLTCqUgEC28fOOuQc4nEg1ExrvWS4swH3k=; b=ol9VpSL0ikoniqBCbj0kBOy5gk+dI3hTILRY0814B6iT4OFb4hMMYCiY+eXZzYYpVZ ssTWSMJk1DRnQqVkEsAlUooQhmLaegdyFtdo0OmLBTrEetTKpkbQ+zsWp+lyIN6P7+wB H+3rexdd3PveS02Gu/26T8eK8F3m5O3TT/b1IkF/BC7awoSCv2pVYMtdQ9vKBgcC0tb1 HA6xDHodUEhyjYDj/hpFpiyuaBO2HSqnwwpT5ddDVUGGIwvuGk5+DKtUtSNxqRMiTZYj 2LdT6M/gAzOz5LR2pM44kVp4OCvETk7HHnaAly5ZfeS8wTC31zIg9NO5UPbV4EI3rZjW SJbg== X-Gm-Message-State: AOJu0YwQgE/7hLG1SQd1LfFdtTqJRDCtmgArwq3Arl8daaPuELvQUH+3 xVhOLwo/jChBfmdtu8aUAg== X-Google-Smtp-Source: AGHT+IHiBM+Pj8rwIjD5f5ElWq7IEopHChL5V1l1hLXxoRScz48VE6f3ZULiu1sG34gKSMusYsFlGQ== X-Received: by 2002:a05:6871:4105:b0:1e9:8e22:24c6 with SMTP id la5-20020a056871410500b001e98e2224c6mr331624oab.44.1699648852849; Fri, 10 Nov 2023 12:40:52 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y22-20020a056870725600b001ea4324364csm61318oaf.12.2023.11.10.12.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:40:52 -0800 (PST) Received: (nullmailer pid 394724 invoked by uid 1000); Fri, 10 Nov 2023 20:40:50 -0000 Date: Fri, 10 Nov 2023 14:40:50 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Tomasz Figa , Jonathan Cameron , linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, Linus Walleij , Krzysztof Kozlowski , Alessandro Zummo , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Daniel Vetter , Ulf Hansson , linux-arm-kernel@lists.infradead.org, David Airlie , Thierry Reding , Jiri Slaby , Liam Girdwood , Mark Brown , Rob Herring , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard , Lee Jones , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org, Thomas Zimmermann , Andi Shyti , linux-rtc@vger.kernel.org, Alim Akhtar , alsa-devel@alsa-project.org, Alexandre Belloni , Lars-Peter Clausen , Greg Kroah-Hartman , Conor Dooley , Jaehoon Chung , dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mmc@vger.kernel.org, Maarten Lankhorst , Sam Protsenko , Sylwester Nawrocki Subject: Re: [PATCH 06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC Message-ID: <169964885014.394659.16948497259010559308.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231108104343.24192-7-krzysztof.kozlowski@linaro.org> On Wed, 08 Nov 2023 11:43:32 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/rtc/s3c-rtc.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > Acked-by: Rob Herring