From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 461231CD25 for ; Wed, 7 Feb 2024 06:21:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707286864; cv=none; b=jKAlvMZaHRHphMG6UWVUbFPiccnTT+Qcylxwbw0dvyVAFw191+2rGxAYwYX3T7oiJcswhf8Ou4x1qX+STaNV6Rj+mg++e9JXiQzw10M/1IcjHK0y5rZIc/xFs4CDYXEmPTunH3KEkxUrE/iBhsfsCqSsXM7tUV+W0hBtj9ysNp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707286864; c=relaxed/simple; bh=l1clcTPdVURHS4P5RVBj+1FOj0fLnM8XRADul96ykm8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XSe7V8ScReOHMvZXPGH+p2j674ELZCqwfGTawTNHXPyXK3VRrh61X/qioeCpl9OBLjSSHPFGwhaL622HeGqDOe0RRlsfwZdydI33LI+Wk0qOBQlQmL76EnwYtra5zuctghONndy9nM4KHnHyaAjOtcGHfGQkNd9KSo/idNs9tPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OhO43A2e; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OhO43A2e" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33b2fba3176so199370f8f.0 for ; Tue, 06 Feb 2024 22:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707286859; x=1707891659; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qZCDdTRk8ciH6FS26XWJyVrDKJALrXXLu6bJhxDtbHY=; b=OhO43A2eEz85oHAAmEJpxzJjlP3U2AbHicGVFZETg9FyoSV+DqKhXwIwO06d/f/v1T 2TIA77WPfijcdrtDwh+BA0ZmcS1oHEGHQDpDoMfMFjd4WRS43h+J9CVtURuRzmDlzmEq w4xuWPxk1Gmgv3UPv0EhdQu8CXqGM0j157OjZXDRQHNCkA9QgYEFZh/286amByS8Ywzi ihJws0BfraV3MJCpLqueYvBEaFvMUdsVO1iejtXCZmj0X+HvHrRCihAEVv7PgipgD+YG u+IXleM/MnIjHeAwQlfOnPuHRx652GqRbAjqrZfWfrI/lVMUwPd9fcjk6lRAhcE7SREN IxwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707286859; x=1707891659; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qZCDdTRk8ciH6FS26XWJyVrDKJALrXXLu6bJhxDtbHY=; b=XgcNgkTYkYb+vzmapvBx5tq7+qT7a2O3t+a5h+iY5tXniBmSjWDHXf6UAF9uEr0LYh P32tb18+6isn3haGrXFhDO9kcI0/iH+Op8UIQOMSnj0p0qlrS7eptDm0FfaPaRjVvu6w QYU/FVL3y8ka4YjlKDb+FyAJYeM75UaIIsGvp+MoBKcCnMB1zQSGtTDfigJ09/4m7YDh 2/K5LOWMpv7qT+KlHDBNx9V/Sca2rqofHZvP6SUuzuWLdQ5aSKYY//AJUoA2r4R2c9cv WEnXv/GUvNwFhMsUrluliJ/1vUO3XiS5fav2Y4mKMrRq6e8Y9yV5esuQ0upKtaHIlYWK Erjg== X-Gm-Message-State: AOJu0YwAU1jPFI+Lxs1LnBH28pUX9oTuuCYfYAfL/xDx5RUmWCGKbGFM 4MGv7YnTbjPdbj5k4V5a01iFrqGlCAD2CFLTIoO/k+tLdjaDKtxze4vGkWbtB8s= X-Google-Smtp-Source: AGHT+IG4xM+HZbEIWxMtNnq3z/vbBUehFRqRlrmFRVXJBVJIfxcsZmP1vgixaZRfj4Dwn64BO86YDQ== X-Received: by 2002:adf:ea11:0:b0:33b:187f:ccc2 with SMTP id q17-20020adfea11000000b0033b187fccc2mr2393960wrm.71.1707286859461; Tue, 06 Feb 2024 22:20:59 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXht0s+5XLYwmbMYGHO9hYHEKtMIUR8SMKjE4DZmjf+xKGxyhIM5rAZEuuWoLJKwsmcjTJs9nRIxCvdnS2zNlZmsth5vb75/NUrmSnamzu6Nt/8tFLcoPOdOgbIVMKx9HBjsF/tXdRsxueEHq+4ftQiT7E1J6bn7RlJrlpF2L3vdespp4G/GGaqNeCTnd8RKoH/7VYvHPHv8ComfNLd6Ci7C7pdZofvJ7hPHSSqahghDNe2LZrxB8TBLGVwLUcZJ1rtmDqSADOu7gwyKM+M49seY5zX8jq7yzu4I0O6Dj8zY8/p4Bh8oDr7vhNQGF9pd+8JR3L1h4gMlWmZHDQsVx2ixvVDwCGBPJ7s4kM6MmkLlMbrdewCARgnf/ojZEYTmog8rkQQEh44gz42ax6rAKg3tGaVvSg4Qa0XZ0mlNdJRenfI3isFZgd4mgXz5eLsmzdEUgx9Kj2BRYUJ9mWKaBa7qxNRi0n9r5aB5yhxKKJ9F3iML0JckyMxbw8R7AF7wVUV1fGE/88WJwOba5dcg/brdetGteJiciGg2I4S18Zxuca6VPNGPUy1tiesEoYgTYmudjw6QJolwQPKUhuzPYmsijAr8tHXsA== Received: from [192.168.0.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id x7-20020a5d54c7000000b0033b444a39a9sm622871wrv.54.2024.02.06.22.20.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Feb 2024 22:20:58 -0800 (PST) Message-ID: <16a5e423-1111-49ff-ad6c-b0bb89a4879a@linaro.org> Date: Wed, 7 Feb 2024 06:20:56 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] spi: s3c64xx: explicitly include Content-Language: en-US To: Sam Protsenko , Greg Kroah-Hartman Cc: broonie@kernel.org, andi.shyti@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, peter.griffin@linaro.org, kernel-team@android.com, willmcvicker@google.com, robh+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org References: <20240206085238.1208256-1-tudor.ambarus@linaro.org> <20240206085238.1208256-2-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/6/24 18:02, Sam Protsenko wrote: > On Tue, Feb 6, 2024 at 2:52 AM Tudor Ambarus wrote: >> >> The driver uses u32 and relies on an implicit inclusion of >> . >> >> It is good practice to directly include all headers used, it avoids >> implicit dependencies and spurious breakage if someone rearranges >> headers and causes the implicit include to vanish. >> >> Include the missing header. >> >> Fixes: 230d42d422e7 ("spi: Add s3c64xx SPI Controller driver") > > Not sure if Fixes tag is needed here. We have already talked about this. If a patch that causes the implicit include to vanish is backported to stable, it will reveal the missing header here and will result in backporting this patch as well. So, as a good practice let's allow this patch to be queued to stable, it will avoid possible compilation errors. I guess Mark has to break the tie again. Or Greg if he cares, I added him in To:. > >> Signed-off-by: Tudor Ambarus >> --- >> drivers/spi/spi-s3c64xx.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 72c35dbe53b2..c15ca6a910dc 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -17,6 +17,7 @@ >> #include >> #include >> #include >> +#include > > Is this really needed for the further patches in this series? > Yes, because in patch 3/4 I use u8 and u16 and I don't want to use those without having the header included. Do you find this wrong? >> >> #define MAX_SPI_PORTS 12 >> #define S3C64XX_SPI_QUIRK_CS_AUTO (1 << 1) >> -- >> 2.43.0.594.gd9cf4e227d-goog >>