From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DE0C77B7A for ; Mon, 29 May 2023 12:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231724AbjE2MWr (ORCPT ); Mon, 29 May 2023 08:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231660AbjE2MWq (ORCPT ); Mon, 29 May 2023 08:22:46 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62CBAC7 for ; Mon, 29 May 2023 05:22:42 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2af2ef0d0daso32215601fa.2 for ; Mon, 29 May 2023 05:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685362960; x=1687954960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YKA7/hMqgo/H6bsA9YWjEB8LXPpVeFefHtEv+Ra/8S4=; b=R27sLwYuiCRCMjqMGuKtvYkajRc9K6BF7541pRI1LprNUjwVpsUbwcL5nrqoArXUpH rca4GzEKl/v2ML1orSY+R5aGxOkr5nWrJZ+tQUWOMIKgNruzbI5ntc67pQsun6iOwvZL JqZKvc9UQoNhSObJ4W1FfTy8Yr4Kj2XUFXQ4dTP19meD7l77J6N1aZs/K/3TJg41gW3R 9wxc6MUO9HjZJ8dOepjLTijzOs3mdbsUssWGrc+ute04IZRyc2MItRRSv7L2WeoiOCMi IuSfNVTEZB494tvEtc9U5eay1SCHTZcrvDtAoIeZmte3ww9KfXjxLm5i7LX5Rljg8jgf qveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685362960; x=1687954960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YKA7/hMqgo/H6bsA9YWjEB8LXPpVeFefHtEv+Ra/8S4=; b=T0xfGXuFTFcyuK0h75N5X/zZDLbBuCOafG9NYuIPv1FRJ3N/++V8kmknlaUGtE50Ky /HL+YKD8tIVGrMXtk5Y2BCHy3v7rqH1+ZVG3pAZjk5GtrMyn6hN+K4Z4jZrw9qtmhdgZ ifGgXx5epwBF91cvYcAioM82Zhj022mdy+7qKAxoDDXEZKS06gSyZNjBQqrcafbqCEMl VzR+Qed2Cv1xE5OtluXFdLNgIDUVXoLblPhpGNMHAZoWkkg8E/XU4OYyMrasMf9haktg fbd0PnbRbM3jx+KCbObFzf5NEAkpwUyymbFtyYis0FCsPUqtjgOdOPEQciVU83fg5vf4 UuTQ== X-Gm-Message-State: AC+VfDznkXp8J9nr4VDgTy9rcoaDJ0Ql9b8Pl8sFWktoVUX99oPuXtzr qZtMje9VP/b5SEqHW/eEzOFZuA== X-Google-Smtp-Source: ACHHUZ5JcAkkevtvFEwgxbEKu/NiJIB1tIffr4Xka3MEQnnoSH+uJnyR56/szW/OTdR2f5nyn5vK6Q== X-Received: by 2002:a2e:9796:0:b0:29c:921c:4eb0 with SMTP id y22-20020a2e9796000000b0029c921c4eb0mr4737453lji.22.1685362960650; Mon, 29 May 2023 05:22:40 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id y28-20020a05651c021c00b002adf8d948dasm2412411ljn.35.2023.05.29.05.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 May 2023 05:22:40 -0700 (PDT) Message-ID: <16ab0b91-1f8b-94ff-6fa6-1d879abc18e4@linaro.org> Date: Mon, 29 May 2023 14:22:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 7/7] ARM: dts: qcom: msm8226: Add mdss nodes Content-Language: en-US To: Dmitry Baryshkov , Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Manikandan , Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230308-msm8226-mdp-v1-0-679f335d3d5b@z3ntu.xyz> <20230308-msm8226-mdp-v1-7-679f335d3d5b@z3ntu.xyz> <6c79b99e-cc69-8cd9-c990-5c0373e1f09c@linaro.org> <58e7e5ff-5e40-7871-efe2-bfe88bd19dad@linaro.org> From: Konrad Dybcio In-Reply-To: <58e7e5ff-5e40-7871-efe2-bfe88bd19dad@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29.05.2023 14:19, Dmitry Baryshkov wrote: > On 29/05/2023 15:10, Konrad Dybcio wrote: >> >> >> On 29.05.2023 11:44, Luca Weiss wrote: >>> Add the nodes that describe the mdss so that display can work on >>> MSM8226. >>> >>> Signed-off-by: Luca Weiss >>> --- >>>   arch/arm/boot/dts/qcom-msm8226.dtsi | 118 ++++++++++++++++++++++++++++++++++++ >>>   1 file changed, 118 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-msm8226.dtsi >>> index 42acb9ddb8cc..182d6405032f 100644 >>> --- a/arch/arm/boot/dts/qcom-msm8226.dtsi >>> +++ b/arch/arm/boot/dts/qcom-msm8226.dtsi >>> @@ -636,6 +636,124 @@ smd-edge { >>>                   label = "lpass"; >>>               }; >>>           }; >>> + >>> +        mdss: display-subsystem@fd900000 { >>> +            compatible = "qcom,mdss"; >>> +            reg = <0xfd900000 0x100>, <0xfd924000 0x1000>; >>> +            reg-names = "mdss_phys", "vbif_phys"; >>> + >>> +            power-domains = <&mmcc MDSS_GDSC>; >>> + >>> +            clocks = <&mmcc MDSS_AHB_CLK>, >>> +                 <&mmcc MDSS_AXI_CLK>, >>> +                 <&mmcc MDSS_VSYNC_CLK>; >>> +            clock-names = "iface", "bus", "vsync"; >> One per line, please >> >>> + >>> +            interrupts = ; >>> + >>> +            interrupt-controller; >>> +            #interrupt-cells = <1>; >> We're not using the irq cell, is that necessary/should that be 0? > > No. With 0 it would mean that there is a single interrupt for mdss source, which clearly is not the case. Obviously. Derp, sorry. Konrad > >> >>> + >>> +            status = "disabled"; >> status should go last >> >>> + >>> +            #address-cells = <1>; >>> +            #size-cells = <1>; >>> +            ranges; >>> + >>> +            mdp: display-controller@fd900000 { >>> +                compatible = "qcom,msm8226-mdp5", "qcom,mdp5"; >>> +                reg = <0xfd900100 0x22000>; >>> +                reg-names = "mdp_phys"; >>> + >>> +                interrupt-parent = <&mdss>; >>> +                interrupts = <0>; >>> + >>> +                clocks = <&mmcc MDSS_AHB_CLK>, >>> +                     <&mmcc MDSS_AXI_CLK>, >>> +                     <&mmcc MDSS_MDP_CLK>, >>> +                     <&mmcc MDSS_VSYNC_CLK>; >>> +                clock-names = "iface", "bus", "core", "vsync"; >> One per line, please >> >>> + >>> +                ports { >>> +                    #address-cells = <1>; >>> +                    #size-cells = <0>; >> Would port { work here? I remember one mdss component's bindings >> didn't allow it but don't recall which one > > Let's use ports /port@0 for uniformity even if there is just a single port always. > >> >>> + >>> +                    port@0 { >>> +                        reg = <0>; >>> +                        mdp5_intf1_out: endpoint { >>> +                            remote-endpoint = <&dsi0_in>; >>> +                        }; >>> +                    }; >>> +                }; >>> +            }; >>> +-- > With best wishes > Dmitry >