From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Tao Zhang <quic_taozha@quicinc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org
Subject: Re: [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver
Date: Mon, 12 Jun 2023 16:35:44 +0100 [thread overview]
Message-ID: <16b08ba8-f23e-af24-881c-61fe4e4c92e1@arm.com> (raw)
In-Reply-To: <1686553666-5811-4-git-send-email-quic_taozha@quicinc.com>
On 12/06/2023 08:07, Tao Zhang wrote:
> Introduce the new subtype of "CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM"
> for TPDM components in driver.
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> drivers/hwtracing/coresight/coresight-core.c | 1 +
> drivers/hwtracing/coresight/coresight-tpdm.c | 2 +-
> include/linux/coresight.h | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> index 118fcf2..23b18c2 100644
> --- a/drivers/hwtracing/coresight/coresight-core.c
> +++ b/drivers/hwtracing/coresight/coresight-core.c
> @@ -1093,6 +1093,7 @@ static int coresight_validate_source(struct coresight_device *csdev,
>
> if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&
> subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
> + subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM &&
minor nit: Alignment. Please always double check your patch for
styling issues.
Otherwise looks good to me
Suzuki
next prev parent reply other threads:[~2023-06-12 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 7:07 [PATCH v5 00/13] Add support to configure TPDM DSB subunit Tao Zhang
2023-06-12 7:07 ` [PATCH v5 01/13] coresight-tpdm: Remove the unnecessary lock Tao Zhang
2023-06-12 7:07 ` [PATCH v5 02/13] dt-bindings: arm: Add support for DSB element size Tao Zhang
2023-06-12 7:07 ` [PATCH v5 03/13] coresight-tpdm: Introduce TPDM subtype to TPDM driver Tao Zhang
2023-06-12 15:35 ` Suzuki K Poulose [this message]
2023-06-15 9:09 ` Tao Zhang
2023-06-12 7:07 ` [PATCH v5 04/13] coresight-tpda: Add DSB dataset support Tao Zhang
2023-06-12 7:07 ` [PATCH v5 05/13] coresight-tpdm: Initialize DSB subunit configuration Tao Zhang
2023-06-12 7:07 ` [PATCH v5 06/13] coresight-tpdm: Add reset node to TPDM node Tao Zhang
2023-06-12 7:07 ` [PATCH v5 07/13] coresight-tpdm: Add nodes to set trigger timestamp and type Tao Zhang
2023-06-12 7:07 ` [PATCH v5 08/13] coresight-tpdm: Add node to set dsb programming mode Tao Zhang
2023-06-12 7:07 ` [PATCH v5 09/13] Add nodes for dsb edge control Tao Zhang
2023-06-12 7:07 ` [PATCH v5 10/13] coresight-tpdm: Add nodes to configure pattern match output Tao Zhang
2023-06-12 7:07 ` [PATCH v5 11/13] coresight-tpdm: Add nodes for timestamp request Tao Zhang
2023-06-12 7:07 ` [PATCH v5 12/13] dt-bindings: arm: Add support for DSB MSR register Tao Zhang
2023-06-12 7:07 ` [PATCH v5 13/13] coresight-tpdm: Add nodes for dsb msr support Tao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16b08ba8-f23e-af24-881c-61fe4e4c92e1@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).