devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25
@ 2024-08-20 12:00 Chukun Pan
  2024-08-20 14:28 ` Dragan Simic
  2024-08-28 15:14 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Chukun Pan @ 2024-08-20 12:00 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, linux-arm-kernel,
	linux-rockchip, devicetree, linux-kernel, Chukun Pan

The SoM board has reserved HDMI output, while the Radxa E25
is not connected. So disable the display subsystem only for
Radxa E25.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 4 ----
 arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts   | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
index 45b03dcbbad4..19d309654bdb 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
@@ -108,10 +108,6 @@ &cpu3 {
 	cpu-supply = <&vdd_cpu>;
 };
 
-&display_subsystem {
-	status = "disabled";
-};
-
 &gpu {
 	mali-supply = <&vdd_gpu>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
index 72ad74c38a2b..84a0789fad96 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
@@ -103,6 +103,10 @@ &combphy1 {
 	phy-supply = <&vcc3v3_pcie30x1>;
 };
 
+&display_subsystem {
+	status = "disabled";
+};
+
 &pcie2x1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie20_reset_h>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25
  2024-08-20 12:00 [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25 Chukun Pan
@ 2024-08-20 14:28 ` Dragan Simic
  2024-08-28 15:14 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Dragan Simic @ 2024-08-20 14:28 UTC (permalink / raw)
  To: Chukun Pan
  Cc: Heiko Stuebner, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
	linux-arm-kernel, linux-rockchip, devicetree, linux-kernel

Hello Chukun,

On 2024-08-20 14:00, Chukun Pan wrote:
> The SoM board has reserved HDMI output, while the Radxa E25
> is not connected. So disable the display subsystem only for
> Radxa E25.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

Looking good to me, thanks for the patch.  The carrier board is what's
responsible for exposing the actual HDMI port from the SoM.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

> ---
>  arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi | 4 ----
>  arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts   | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> index 45b03dcbbad4..19d309654bdb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-cm3i.dtsi
> @@ -108,10 +108,6 @@ &cpu3 {
>  	cpu-supply = <&vdd_cpu>;
>  };
> 
> -&display_subsystem {
> -	status = "disabled";
> -};
> -
>  &gpu {
>  	mali-supply = <&vdd_gpu>;
>  	status = "okay";
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> index 72ad74c38a2b..84a0789fad96 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> @@ -103,6 +103,10 @@ &combphy1 {
>  	phy-supply = <&vcc3v3_pcie30x1>;
>  };
> 
> +&display_subsystem {
> +	status = "disabled";
> +};
> +
>  &pcie2x1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pcie20_reset_h>;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25
  2024-08-20 12:00 [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25 Chukun Pan
  2024-08-20 14:28 ` Dragan Simic
@ 2024-08-28 15:14 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2024-08-28 15:14 UTC (permalink / raw)
  To: Chukun Pan
  Cc: Heiko Stuebner, linux-kernel, devicetree, linux-arm-kernel,
	Conor Dooley, Krzysztof Kozlowski, Rob Herring, linux-rockchip

On Tue, 20 Aug 2024 20:00:20 +0800, Chukun Pan wrote:
> The SoM board has reserved HDMI output, while the Radxa E25
> is not connected. So disable the display subsystem only for
> Radxa E25.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25
      commit: 5d4b29c2bf1b2b08522c48f211311404b8075bd1

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-28 15:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 12:00 [PATCH 1/1] arm64: dts: rockchip: disable display subsystem only for Radxa E25 Chukun Pan
2024-08-20 14:28 ` Dragan Simic
2024-08-28 15:14 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).