From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, Andrew Davis <afd@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <andersson@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Heiko Stuebner <heiko@sntech.de>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michal Simek <michal.simek@amd.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Nishanth Menon <nm@ti.com>, Olof Johansson <olof@lixom.net>,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] docs: dt-bindings: add DTS Coding Style document
Date: Tue, 21 Nov 2023 08:47:45 +0100 [thread overview]
Message-ID: <16cba31d-534a-4658-868a-c1ff3165cf11@linaro.org> (raw)
In-Reply-To: <14c3900f-8f2e-4614-8317-f85763d1d953@lunn.ch>
On 20/11/2023 21:15, Andrew Lunn wrote:
>> +Naming and Valid Characters
>> +---------------------------
>> +
>> +1. Node and property names are allowed to use only:
>> +
>> + * lowercase characters: [a-z]
>> + * digits: [0-9]
>> + * dash: -
>> +
>> +2. Labels are allowed to use only:
>> +
>> + * lowercase characters: [a-z]
>> + * digits: [0-9]
>> + * underscore: _
>> +
>> +3. Unit addresses should use lowercase hex, without leading zeros (padding).
>> +
>> +4. Hex values in properties, e.g. "reg", should use lowercase hex. The address
>> + part can be padded with leading zeros.
>> +
>> +Example::
>> +
>> + gpi_dma2: dma-controller@800000 {
>> + compatible = "qcom,sm8550-gpi-dma", "qcom,sm6350-gpi-dma";
>> + reg = <0x0 0x00800000 0x0 0x60000>;
>> + }
>
> Hi Krzysztof
>
> What i like about the Linux Coding Style is that most sections have a
> Rationale. I like the way it explains the 'Why?'. It makes it feel
> less arbitrary. When it does not seem arbitrary, but reasoned, i find
> it easier to follow.
>
> Could you add rationale like the Coding Style?
I did not do it on purpose because it would grow too much.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-21 7:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:40 [PATCH v2] docs: dt-bindings: add DTS Coding Style document Krzysztof Kozlowski
2023-11-20 9:04 ` Neil Armstrong
2023-11-20 9:38 ` Heiko Stübner
2023-11-20 11:43 ` AngeloGioacchino Del Regno
2023-11-20 14:57 ` Krzysztof Kozlowski
2023-11-21 10:25 ` AngeloGioacchino Del Regno
2023-11-20 14:01 ` Michal Simek
2023-11-20 14:53 ` Krzysztof Kozlowski
2023-11-20 19:18 ` Geert Uytterhoeven
2023-11-20 19:31 ` Krzysztof Kozlowski
2023-11-21 7:33 ` Michal Simek
2023-11-21 7:47 ` Krzysztof Kozlowski
2023-11-21 8:08 ` Geert Uytterhoeven
2023-11-21 8:37 ` Krzysztof Kozlowski
2023-11-21 10:13 ` Dmitry Baryshkov
2023-11-21 10:28 ` Krzysztof Kozlowski
2023-11-21 11:53 ` Michal Simek
2023-11-21 11:55 ` Michal Simek
2023-11-21 12:36 ` Krzysztof Kozlowski
2023-11-21 16:04 ` Geert Uytterhoeven
2023-11-22 8:01 ` Krzysztof Kozlowski
2023-11-22 8:15 ` Dragan Simic
2023-11-20 20:15 ` Andrew Lunn
2023-11-21 7:36 ` Michal Simek
2023-11-21 7:47 ` Krzysztof Kozlowski [this message]
2023-11-22 8:18 ` Krzysztof Kozlowski
2023-11-21 13:50 ` Rafał Miłecki
2023-11-22 8:05 ` Krzysztof Kozlowski
2023-11-22 8:09 ` Chen-Yu Tsai
2023-11-22 8:21 ` Krzysztof Kozlowski
2023-11-22 8:28 ` Geert Uytterhoeven
2023-11-22 8:29 ` Dragan Simic
2023-11-22 8:49 ` Michal Simek
2023-11-22 8:53 ` Geert Uytterhoeven
2023-11-22 8:57 ` Michal Simek
2023-11-22 9:09 ` Krzysztof Kozlowski
2023-11-22 14:34 ` Rob Herring
2023-11-22 14:42 ` Dragan Simic
2023-11-22 8:59 ` Dragan Simic
2023-11-22 14:55 ` Rob Herring
2023-11-25 18:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16cba31d-534a-4658-868a-c1ff3165cf11@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).