From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D34C433E4 for ; Thu, 16 Jul 2020 20:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 796B3207FB for ; Thu, 16 Jul 2020 20:25:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fKlGp8tN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725948AbgGPUZX (ORCPT ); Thu, 16 Jul 2020 16:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgGPUZW (ORCPT ); Thu, 16 Jul 2020 16:25:22 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5285BC061755; Thu, 16 Jul 2020 13:25:22 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id d17so9810950ljl.3; Thu, 16 Jul 2020 13:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2B3j92dSMko8J2wSzj/MTkQ80Lgndi5SU2LXd/AvSxg=; b=fKlGp8tNNQTRc2pZ/k7DJXl/e+y+EMOltfn0ctkc5TBjudSyx4+OmmzC1cPseIz5TZ EhZ7SkVqtunfTCqDyTjnpz6enopRHyyFyicsv7j+SU1XozXwrLzP+j84rkTbX/9c5yag rydqve0KDjL7dKEwcDpd7oSgHp+Ato4HPEAvlKdEJp63yTjr7a1wUlMCNrz5gRc/dz4x 2INFC8HTbOhvfnn7RMjv05K2XU/hrDQnPf1WHFo3IUn+hoRW3w23q+wrNabjbG+6zZ/H SjLTz7a4dTsXazlzCfKd8IPqfa0/ZL/rt7Nt/RE3iqc6VFScfw5RosF/CBvwsshburFx 7zig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2B3j92dSMko8J2wSzj/MTkQ80Lgndi5SU2LXd/AvSxg=; b=HXcHexAI6XI+zJ5SeO782Wwr1vCJ2LnwgfuEpwlubaEHYNQgmHzSYj14C0xRWNCvGN L0GxIcohiFiZKyCjY8wkAlvkXkAAljhUCLBcXH8rTiAHzRyOsdyEjR8KriEwsBCrcgfx JDWcKRH1EDkNAJ2fndmW1r/Oha+h1ZbsoASn7UquqilekY3qMAkAyX7Cc8bbqzYeIE4C OuzwjKxgNVcG4RUGK8FMu0ybQSChSFGlv6Ay9aFuREPfEoHPmPyIWve7xaXRx6i5dEe6 Y2N2KYhq0LvSz1LHUwW55fL9CT5sClakkXeNDRrozp01vneisoyABE3UA3M8PiUpPBfd f9cA== X-Gm-Message-State: AOAM530B2Ii4eybm7t8mhOLY6KoMC9gL/UjwYv3AVl6dCwylaRuJ7zLz 4Ot9MNfWYI1Dn71l547hTB8ixMj+ X-Google-Smtp-Source: ABdhPJyy6GDksC2tHtwyAvGIf4mNUlDUF9P1X/kNsZoQJmE7dlwHaYHrNOQbrgaWGK4EiTSpdMRW7A== X-Received: by 2002:a2e:92d7:: with SMTP id k23mr2566872ljh.117.1594931120478; Thu, 16 Jul 2020 13:25:20 -0700 (PDT) Received: from [192.168.2.145] (ppp91-76-4-184.pppoe.mtu-net.ru. [91.76.4.184]) by smtp.googlemail.com with ESMTPSA id j26sm1396678lfm.11.2020.07.16.13.25.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 13:25:19 -0700 (PDT) Subject: Re: [RFC PATCH v3 04/18] i2c: tegra: Remove NULL pointer check before clk_enable/disable/prepare/unprepare To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi, robh+dt@kernel.org, helen.koike@collabora.com Cc: sboyd@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org References: <1594786855-26506-1-git-send-email-skomatineni@nvidia.com> <1594786855-26506-5-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <16e08405-8b71-e427-e675-6499e012a5b6@gmail.com> Date: Thu, 16 Jul 2020 23:25:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594786855-26506-5-git-send-email-skomatineni@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 15.07.2020 07:20, Sowjanya Komatineni пишет: > clk_enable, clk_disable, clk_prepare, and clk_unprepare APIs have > implementation for checking clk pointer not NULL and clock consumers > can safely call these APIs without NULL pointer check. > > So, this patch cleans up Tegra i2c driver to remove explicit checks > before these APIs. > > Signed-off-by: Sowjanya Komatineni > --- Thanks! Reviewed-by: Dmitry Osipenko