* [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial
2023-01-23 12:56 [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
@ 2023-01-23 12:56 ` Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio
2023-01-23 12:56 ` [PATCH v2 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 12:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so adderss/size cells are not correct.
Fixes: cf03cd7e12bd ("arm64: dts: qcom: sm8350: Set up WRAP0 QUPs")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. None
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 4efe79985186..018f26f729f1 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1031,8 +1031,6 @@ uart2: serial@98c000 {
interrupts = <GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>;
power-domains = <&rpmhpd SM8350_CX>;
operating-points-v2 = <&qup_opp_table_100mhz>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial
2023-01-23 12:56 ` [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
@ 2023-01-23 16:29 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-01-23 16:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
On 23.01.2023 13:56, Krzysztof Kozlowski wrote:
> The serial/UART device node does not have children with unit addresses,
> so adderss/size cells are not correct.
>
> Fixes: cf03cd7e12bd ("arm64: dts: qcom: sm8350: Set up WRAP0 QUPs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> 1. None
> ---
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 4efe79985186..018f26f729f1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -1031,8 +1031,6 @@ uart2: serial@98c000 {
> interrupts = <GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>;
> power-domains = <&rpmhpd SM8350_CX>;
> operating-points-v2 = <&qup_opp_table_100mhz>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial
2023-01-23 12:56 [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-23 12:56 ` [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
@ 2023-01-23 12:56 ` Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio
2023-01-23 12:56 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-01-23 16:27 ` [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Konrad Dybcio
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 12:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so adderss/size cells are not correct.
Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. None
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index d66dcd8fe61f..395a3a156e24 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1017,8 +1017,6 @@ uart20: serial@894000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart20_default>;
interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
@@ -1411,8 +1409,6 @@ uart7: serial@99c000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 3/4] arm64: dts: qcom: sm8450: drop incorrect cells from serial
2023-01-23 12:56 ` [PATCH v2 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
@ 2023-01-23 16:29 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-01-23 16:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
On 23.01.2023 13:56, Krzysztof Kozlowski wrote:
> The serial/UART device node does not have children with unit addresses,
> so adderss/size cells are not correct.
>
> Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
> Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> 1. None
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index d66dcd8fe61f..395a3a156e24 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -1017,8 +1017,6 @@ uart20: serial@894000 {
> pinctrl-names = "default";
> pinctrl-0 = <&qup_uart20_default>;
> interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
>
> @@ -1411,8 +1409,6 @@ uart7: serial@99c000 {
> pinctrl-names = "default";
> pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
> interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sm8550: drop incorrect cells from serial
2023-01-23 12:56 [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
2023-01-23 12:56 ` [PATCH v2 2/4] arm64: dts: qcom: sm8350: drop incorrect cells from serial Krzysztof Kozlowski
2023-01-23 12:56 ` [PATCH v2 3/4] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
@ 2023-01-23 12:56 ` Krzysztof Kozlowski
2023-01-23 16:29 ` Konrad Dybcio
2023-01-23 16:27 ` [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Konrad Dybcio
3 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 12:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The serial/UART device node does not have children with unit addresses,
so adderss/size cells are not correct.
Fixes: 377972ac743f ("arm64: dts: qcom: sm8550: add I2C Master Hub nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. New patch
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 6ff135191ee0..0307b853ec4f 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1582,8 +1582,6 @@ uart7: serial@a9c000 {
interconnect-names = "qup-core", "qup-config";
interconnects = <&clk_virt MASTER_QUP_CORE_1 0 &clk_virt SLAVE_QUP_CORE_1 0>,
<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>;
- #address-cells = <1>;
- #size-cells = <0>;
status = "disabled";
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8550: drop incorrect cells from serial
2023-01-23 12:56 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
@ 2023-01-23 16:29 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-01-23 16:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
On 23.01.2023 13:56, Krzysztof Kozlowski wrote:
> The serial/UART device node does not have children with unit addresses,
> so adderss/size cells are not correct.
>
> Fixes: 377972ac743f ("arm64: dts: qcom: sm8550: add I2C Master Hub nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> 1. New patch
> ---
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 6ff135191ee0..0307b853ec4f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -1582,8 +1582,6 @@ uart7: serial@a9c000 {
> interconnect-names = "qup-core", "qup-config";
> interconnects = <&clk_virt MASTER_QUP_CORE_1 0 &clk_virt SLAVE_QUP_CORE_1 0>,
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QUP_1 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth
2023-01-23 12:56 [PATCH v2 1/4] arm64: dts: qcom: use generic node name for Bluetooth Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-23 12:56 ` [PATCH v2 4/4] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
@ 2023-01-23 16:27 ` Konrad Dybcio
3 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2023-01-23 16:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Dmitry Baryshkov, Vinod Koul, Neil Armstrong,
linux-arm-msm, devicetree, linux-kernel
On 23.01.2023 13:56, Krzysztof Kozlowski wrote:
> Node names should be generic (as Devicetree spec mandates), so use
> "bluetooth" for BT node.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
>
> Changes since v1:
> 1. Fix also msm8996-xiaomi-common
> ---
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +-
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> index 5b47b8de69da..2acfed28e3cb 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
> @@ -229,7 +229,7 @@ &blsp1_uart2 {
> status = "okay";
> label = "QCA_UART";
>
> - bluetooth: qca6174a {
> + bluetooth: bluetooth {
> compatible = "qcom,qca6174-bt";
>
> enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 774f9d45f051..6ea8dd7d3e01 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -430,7 +430,7 @@ &uart3 {
> pinctrl-names = "default", "sleep";
> pinctrl-1 = <&qup_uart3_sleep>;
>
> - bluetooth: wcn3990-bt {
> + bluetooth: bluetooth {
> compatible = "qcom,wcn3990-bt";
> vddio-supply = <&vreg_l10a_1p8>;
> vddxo-supply = <&vreg_l1c_1p8>;
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> index a78075155310..e19178c1ec44 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
> @@ -862,7 +862,7 @@ &uart6 {
>
> pinctrl-0 = <&qup_uart6_4pin>;
>
> - bluetooth: wcn3990-bt {
> + bluetooth: bluetooth {
> compatible = "qcom,wcn3990-bt";
> vddio-supply = <&src_pp1800_s4a>;
> vddxo-supply = <&pp1800_l7a_wcn3990>;
^ permalink raw reply [flat|nested] 8+ messages in thread