devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
	Kukjin Kim <kgene@kernel.org>,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250
Date: Mon, 31 Aug 2020 13:03:19 +0200	[thread overview]
Message-ID: <1700b99a-4b57-2aa2-50f5-a2dcf32b037e@samsung.com> (raw)
In-Reply-To: <20200829172532.29358-2-krzk@kernel.org>

On 29.08.2020 19:25, Krzysztof Kozlowski wrote:
> The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a
> fake "reg" was added.  This is not correct with dtschema as fixed-clock
> binding does not have a "reg" property:
>
>    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>   arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------
>   1 file changed, 17 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index d3fb45a56527..c67c70e46794 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -97,33 +97,25 @@
>   		};
>   	};
>   
> -	fixed-rate-clocks {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		xusbxti: clock@0 {
> -			compatible = "fixed-clock";
> -			reg = <0>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xusbxti";
> -		};
> +	xusbxti: clock-0 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xusbxti";
> +	};
>   
> -		xxti: clock@1 {
> -			compatible = "fixed-clock";
> -			reg = <1>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xxti";
> -		};
> +	xxti: clock-1 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xxti";
> +	};
>   
> -		xtcxo: clock@2 {
> -			compatible = "fixed-clock";
> -			reg = <2>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xtcxo";
> -		};
> +	xtcxo: clock-2 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xtcxo";
>   	};
>   
>   	pmu {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  reply	other threads:[~2020-08-31 11:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 17:25 [PATCH 1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03 Krzysztof Kozlowski
2020-08-29 17:25 ` [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250 Krzysztof Kozlowski
2020-08-31 11:03   ` Marek Szyprowski [this message]
2020-09-01 10:15   ` Krzysztof Kozlowski
2020-08-29 17:25 ` [RFT 3/4] ARM: dts: exynos: Move CMU assigned ISP clocks to buses " Krzysztof Kozlowski
2020-08-31  8:11   ` Marek Szyprowski
2020-08-31  8:19     ` Krzysztof Kozlowski
2020-08-31  8:29       ` Marek Szyprowski
2020-08-31  8:31       ` Krzysztof Kozlowski
2020-08-29 17:25 ` [PATCH 4/4] ARM: dts: exynos: Remove snps,dwc2 compatible " Krzysztof Kozlowski
2020-09-02 15:35   ` Krzysztof Kozlowski
2020-08-29 21:06 ` [PATCH 1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03 Sam Ravnborg
2020-09-14 18:16 ` [PATCH 1/4] dt-bindings: display: samsung, amoled-mipi-dsi: Do not require enable-gpios on samsung, s6e63j0x03 Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1700b99a-4b57-2aa2-50f5-a2dcf32b037e@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hoegeun.kwon@samsung.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=snawrocki@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).